summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Joey Hess <joey@kitenet.net>2012-09-28 12:56:58 -0400
committerGravatar Joey Hess <joey@kitenet.net>2012-09-28 12:56:58 -0400
commitd0c1cffa6f2b043ff12e634d56ae4d049f7816e1 (patch)
tree1572070335ddb04cc30d796d067281dc8931fa92
parentb276b5db8257526ccbcf5f37050f61edef011f9c (diff)
close unreproducible bug and remove expensive code added to debug it
-rw-r--r--Assistant/Threads/Committer.hs9
-rw-r--r--doc/bugs/lsof__47__committer_thread_loops_occassionally.mdwn2
2 files changed, 2 insertions, 9 deletions
diff --git a/Assistant/Threads/Committer.hs b/Assistant/Threads/Committer.hs
index 946726c79..62058f4f4 100644
--- a/Assistant/Threads/Committer.hs
+++ b/Assistant/Threads/Committer.hs
@@ -205,15 +205,6 @@ safeToAdd st changes = runThreadState st $
openfiles <- S.fromList . map fst3 . filter openwrite <$>
liftIO (Lsof.queryDir tmpdir)
- -- TODO this is here for debugging a problem on
- -- OSX, and is pretty expensive, so remove later
- liftIO $ debug thisThread
- [ "checking changes:"
- , show changes
- , "vs open files:"
- , show openfiles
- ]
-
let checked = map (check openfiles) changes
{- If new events are received when files are closed,
diff --git a/doc/bugs/lsof__47__committer_thread_loops_occassionally.mdwn b/doc/bugs/lsof__47__committer_thread_loops_occassionally.mdwn
index 14c47e73d..335581e20 100644
--- a/doc/bugs/lsof__47__committer_thread_loops_occassionally.mdwn
+++ b/doc/bugs/lsof__47__committer_thread_loops_occassionally.mdwn
@@ -49,3 +49,5 @@ Already up-to-date.
I ran " git annex watch -d --foreground" to watch what was going one, and just created a .gitignore file and the the commiter/lsof thread just loops over and over.... I only noticed as my laptop battery had drained at somepoint when git-annex was running in the background.
[[!meta title="assistant: lsof/committer thread loops occassionally"]]
+
+> Closing this since it doesn't seem reproducible. [[done]] --[[Joey]]