diff options
| author |  Joey Hess <joey@kitenet.net> | 2011-08-27 12:34:02 -0400 |
|---|---|---|
| committer | Joey Hess <joey@kitenet.net> | 2011-08-27 12:34:02 -0400 |
| commit | b26ee162f33858aa4ef82fbe3d56eecc00590755 (patch) | |
| tree | 61948b08f7dd069f972e40faabd24102ea438549 | |
| parent | 6e750764b7d30d9cb0684cdaadd79ec091a4fda6 (diff) | |
guess not everyone configures their shell to show nonzero exit codes..
| -rw-r--r-- | Makefile | 4 | ||||
| -rw-r--r-- | doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn | 2 |
2 files changed, 5 insertions, 1 deletions
@@ -53,7 +53,9 @@ test: $(bins) @if ! $(GHCMAKE) -O0 test; then \ echo "** not running test suite" >&2; \ else \ - ./test; \ + if ! ./test; then \ + echo "** test suite failed!" >&2; \ + fi; \ fi testcoverage: $(bins) diff --git a/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn b/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn index 7a579f8fe..2f486ad65 100644 --- a/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn +++ b/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn @@ -1 +1,3 @@ When the test suite cannot be compiled, the build just fails silenty. This means that in automated builds there is no easy way to ensure that the generated binaries have passed the test suite, because it may not even have been run! IMHO, "make test" should fail (i.e. return a non-zero exit code) when it can't succeeed. + +> Ok, fixed. --[[Joey]] [[done]] |