aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* fix fork debug printf() callsGravatar Kurtis Rader2016-05-05
| | | | | | | | The fork (create new process) related debugging messages rely on an undocumented env var and use `printf()` rather than `debug()`. There are also errors in how the fork count is tracked that this fixes. Fixes #2995
* lint: low hanging fruit in history.cppGravatar Kurtis Rader2016-05-05
|
* lint: screen.cpp low hanging fruitGravatar Kurtis Rader2016-05-04
| | | | | The remaining lint work to be done on screen.cpp will require refactoring several functions that are way too large and complex.
* lint cleanup: eliminate "redundant" errorsGravatar Kurtis Rader2016-05-04
| | | | | This removes some pointless parentheses but the primary focus is removing redundancies like unnecessary "else" clauses.
* eliminate "useless parentheses" lint errorsGravatar Kurtis Rader2016-05-03
| | | | | | | Some `oclint` errors regarding "useless parentheses" are meaningfull. But the vast majority are bogus in as much as removing the parentheses reduces readability. So fix a few of the egregious uses and otherwise suppress that error.
* add missing fallback declarationsGravatar Kurtis Rader2016-05-03
| | | | Fixes #2993
* restyle switch blocks to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | | | | | | | | | | I missed restyling a few "switch" blocks to make them consistent with the rest of the code base. This fixes that oversight. This should be the final step in restyling the C++ code to have a consistent style. This also includes a few trivial cleanups elsewhere. I also missed restyling the "complete" module when working my way from a to z so this final change includes restyling that module. Total lint errors decreased 36%. Cppcheck errors went from 47 to 24. Oclint P2 errors went from 819 to 778. Oclint P3 errors went from 3252 to 1842. Resolves #2902.
* restyle remaining modules to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | | | | For this change I decided to bundle the remaining modules that need to be resytyled because only two were large enough to warrant doing on their own. Reduces lint errors from 225 to 162 (-28%). Line count from 3073 to 2465 (-20%). Another step in resolving issue #2902.
* restyle utf8 module to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | Reduces lint errors from 63 to 57 (-10%). Line count from 518 to 418 (-19%). Another step in resolving issue #2902.
* restyle tokenizer module to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | Reduces lint errors from 70 to 46 (-34%). Line count from 1158 to 936 (-19%). Another step in resolving issue #2902.
* restyle signal module to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | Reduces lint errors from 15 to 15 (-0%). Line count from 754 to 438 (-42%). Another step in resolving issue #2902.
* restyle sanity & screen module to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | Reduces lint errors from 163 to 112 (-31%). Line count from 1866 to 1493 (-20%). Another step in resolving issue #2902.
* restyle reader module to match project styleGravatar Kurtis Rader2016-05-03
| | | | | | Reduces lint errors from 338 to 205 (-39%). Line count from 4650 to 3654 (-21%). Another step in resolving issue #2902.
* Suppress another pointless IWYU warningGravatar Kurtis Rader2016-05-02
|
* restyle proc module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 134 to 101 (-25%). Line count from 1994 to 1466 (-26%). Another step in resolving issue #2902.
* restyle postfork module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 37 to 20 (-46%). Line count from 670 to 566 (-15%). Another step in resolving issue #2902.
* restyle path module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 30 to 21 (-30%). Line count from 597 to 481 (-19%). Another step in resolving issue #2902.
* restyle parser module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 72 to 44 (-43%). Line count from 1698 to 1313 (-23%). Another step in resolving issue #2902.
* restyle parse_util module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 187 to 91 (-51%). Line count from 1754 to 1477 (-16%). Another step in resolving issue #2902.
* restyle parse_tree module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 163 to 52 (-68%). Line count from 2012 to 1904 (-5%). Another step in resolving issue #2902.
* restyle parse_productions module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 33 to 9 (-73%). Line count from 551 to 534 (-3%). Another step in resolving issue #2902.
* restyle parse_execution module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 184 to 84 (-54%). Line count from 2139 to 1943 (-9%). Another step in resolving issue #2902.
* restyle pager & lru module to match project styleGravatar Kurtis Rader2016-05-02
| | | | | | Reduces lint errors from 65 to 25 (-63%). Line count from 1439 to 1218 (-15%). Another step in resolving issue #2902.
* restyle output module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 34 to 31 (-9%). Line count from 712 to 535 (-25%). Another step in resolving issue #2902.
* restyle kill module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 10 to 9 (-10%). Line count from 242 to 175 (-28%). Another step in resolving issue #2902.
* restyle iothread module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 41 to 26 (-37%). Line count from 444 to 423 (-5%). Another step in resolving issue #2902.
* restyle io module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 15 to 10 (-33%). Line count from 637 to 489 (-23%). Another step in resolving issue #2902.
* restyle intern module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 8 to 6 (-25%). Line count from 112 to 83 (-26%). Another step in resolving issue #2902.
* restyle input_common module to match project styleGravatar Kurtis Rader2016-05-01
| | | | | | Reduces lint errors from 27 to 24 (-11%). Line count from 466 to 378 (-19%). Another step in resolving issue #2902.
* restyle input module to match project styleGravatar Kurtis Rader2016-04-30
| | | | | | Reduces lint errors from 69 to 48 (-30%). Line count from 1270 to 1044 (-18%). Another step in resolving issue #2902.
* restyle highlight module to match project styleGravatar Kurtis Rader2016-04-30
| | | | | | Reduces lint errors from 176 to 69 (-61%). Line count from 1627 to 1426 (-12%). Another step in resolving issue #2902.
* restyle function module to match project styleGravatar Kurtis Rader2016-04-30
| | | | | | Reduces lint errors from 39 to 27 (-31%). Line count from 619 to 498 (-20%). Another step in resolving issue #2902.
* restyle fish modules to match project styleGravatar Kurtis Rader2016-04-30
| | | | | | Reduces lint errors from 60 to 60 (-0%). Line count from 5599 to 4925 (-12%). Another step in resolving issue #2902.
* restyle fallback module to match project styleGravatar Kurtis Rader2016-04-30
| | | | | | | | | | Reduces lint errors from 36 to 33 (-8%). Line count from 1910 to 1476 (-23%). Another step in resolving issue #2902. This also fixes a stupid mistake from an earlier commit where I didn't realize that osx/config.h was meant to be included as a semi-static file in the repository.
* Remove use of __environGravatar ridiculousfish2016-04-30
| | | | It has apparently never worked. Fixes #2988
* Remove some unused macros from builtin_set_color.cppGravatar ridiculousfish2016-04-29
|
* Issue a \r in fish_title, except when executing it for the promptGravatar ridiculousfish2016-04-29
| | | | | | | | | | | fish_title currently outputs some escaped text, which can confuse the line driver (#2453). Issue a carriage return so the line driver knows we are at the beginning of the line, unless we are writing the title as part of the prompt. In that case, we may have text from the previous command still on the line and we don't want to move the cursor. Fixes #2453
* restyle expand module to match project styleGravatar Kurtis Rader2016-04-28
| | | | | | Reduces lint errors from 183 to 126 (-31%). Line count from 2231 to 1787 (-20%). Another step in resolving issue #2902.
* restyle exec module to match project styleGravatar Kurtis Rader2016-04-28
| | | | | | Reduces lint errors from 121 to 59 (-51%). Line count from 1578 to 1290 (-18%). Another step in resolving issue #2902.
* retyle event module to match project styleGravatar Kurtis Rader2016-04-28
| | | | | | Reduces lint errors from 39 to 30 (-23%). Line count from 915 to 670 (-27%). Another step in resolving issue #2902.
* restyle env_universal module to match project styleGravatar Kurtis Rader2016-04-28
| | | | | | Reduces lint errors from 121 to 52 (-57%). Line count from 1916 to 1671 (-13%). Another step in resolving issue #2902.
* restyle env module to match project styleGravatar Kurtis Rader2016-04-28
| | | | | | Reduces lint errors from 90 to 72 (-20%). Line count from 1719 to 1298 (-24%). Another step in resolving issue #2902.
* provide a realpath implementationGravatar Kurtis Rader2016-04-28
| | | | | | | Not all distros have a `realpath` command. Provide a function that uses the real command if available else use the fish builtin. Fixes #2932
* restyle common module to match project styleGravatar Kurtis Rader2016-04-27
| | | | | | Reduces lint errors from 194 to 142 (-27%). Line count from 3352 to 2645 (-21%). Another step in resolving issue #2902.
* restyle color module to match project styleGravatar Kurtis Rader2016-04-27
| | | | | | Reduces lint errors from 16 to 14 (-13%). Line count from 558 to 463 (-17%). Another step in resolving issue #2902.
* compile fallback.cpp and util.cpp seperatelyGravatar Kurtis Rader2016-04-27
| | | | | | | Don't `#include "*.cpp"` modules in other cpp modules. I already took care of all the builtin_*.cpp modules in my previous change where I restyled the builtin code. This change fixes the two remaining instances of this anti-pattern.
* env_universal_common.cpp: pass correct flag to fcntlGravatar David Adam2016-04-27
| | | | | | Closes #2955. (cherry picked from commit d5797c543982a0fbc8201ae21db5009e9447f75d)
* restyle builtin modules to match project styleGravatar Kurtis Rader2016-04-26
| | | | | | | | | | | Now that the IWYU cleanup has been merged compile all, not just a couple, of the builtin modules independent of builtin.cpp. That is, no longer `#include builtin_NAME.cpp` in builtin.cpp. This is more consistent, more in line with what developers expect, and is likely to reduce mistakes. Reduces lint errors from 384 to 336 (-13%). Line count from 6307 to 4988 (-21%). Another step in resolving issue #2902.
* Update usage of pcre2_substitute() for pcre2-10.21Gravatar Michael Steed2016-04-27
| | | | | | | - Set PCRE2_SUBSTITUTE_OVERFLOW_LENGTH to get the required buffer length from pcre2 instead of guessing - Set PCRE2_SUBSTITUTE_EXTENDED to enable extra goodies in the replacement string
* add better support for IWYU and fix thingsGravatar Kurtis Rader2016-04-26
| | | | | | | | | Remove the "make iwyu" build target. Move the functionality into the recently introduced lint.fish script. Fix a lot, but not all, of the include-what-you-use errors. Specifically, it fixes all of the IWYU errors on my OS X server but only removes some of them on my Ubuntu 14.04 server. Fixes #2957
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-16 17:21:27 +0000