| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| |
|
|
| |
And re-run IWYU, adjust #includes.
|
| |
|
|
|
|
|
| |
This remove some stores that clang assures me are very dead.
And an assert() for an unlikely NULL pointer dereference I can't quite
figure out.
|
| |
|
|
|
|
|
|
| |
This only eliminates errors reported by `make lint`. It shouldn't cause any
functional changes.
This change does remove several functions that are unused. It also removes the
`desc_arr` variable which is both unused and out of date with reality.
|
| |
|
|
|
|
|
|
| |
The autoconf-generated config.h contains a number of directives which
may alter the behaviour of system headers on certain platforms. Always
include it in every C++ file as the first include.
Closes #2993.
|
| |
|
|
|
|
| |
I'm doing this as part of fixing issue #2980. The code for managing tty modes
and job control is a horrible mess. This is a very tiny step towards improving
the situation.
|
| |
|
|
|
| |
This removes some pointless parentheses but the primary focus is removing
redundancies like unnecessary "else" clauses.
|
| |
|
|
|
|
| |
Reduces lint errors from 163 to 52 (-68%). Line count from 2012 to 1904 (-5%).
Another step in resolving issue #2902.
|
| |
|
|
|
|
|
|
|
| |
Remove the "make iwyu" build target. Move the functionality into the
recently introduced lint.fish script. Fix a lot, but not all, of the
include-what-you-use errors. Specifically, it fixes all of the IWYU errors
on my OS X server but only removes some of them on my Ubuntu 14.04 server.
Fixes #2957
|
| |
|
|
|
|
|
|
|
|
|
| |
In keeping with the change made by @ridiculousfish earlier today modify
the `keyword_description()` function to return a const wchar_t pointer.
Also, simplify the `token_type_description()` function to use the recently
introduced mapping array. This changes the wording of many of the token
type descriptions. However, I can't see this as being a problem since
the original descriptions (e.g., "token_redirection") are no clearer to
someone not acquainted with the implementation.
|
| |
|
|
|
|
|
|
|
|
|
| |
Fish keywords can be quoted and split across lines. Prior to this change
`fish_indent` would retain such odd, obfuscated, formatting. This change
results in all keywords being converted to their canonical form.
This required fixing a bug: the keyword member of parse_node_t wasn't being
populated. This hadn't been noticed prior to now because it wasn't used.
Fixes #2921
|
| |
|
|
| |
Reduces allocations and startup time
|
| |
|
|
|
|
|
| |
This behavior is more consistent with line continuation in strings other
than keywords.
Fixes #2897
|
| |
|
|
|
|
|
|
| |
Modify `fish_indent` to emit redirections without a space before the target of
the redirection; e.g., "2>&1" rather than "2>& 1" as the former is clearer to
humans.
Fixes #2899
|
| |
|
|
|
|
| |
Refine the linting behavior.
Fix several of the, mostly trivial, lint errors.
|
| |
|
|
| |
This prevents undesired implicit conversions
|
| |
|
|
| |
Bitfields ftw
|
| |
|
|
|
|
|
|
|
|
| |
For example:
if false; or true; echo hello; end
will output 'hello' now.
Fixes #1428
|
| |
|
|
|
|
|
|
| |
Rather than returning a list of productions and an index,
return the relevant production directly from the rule function.
Also introduce a tag value (replacing production_idx) which tracks
information like command decorations, etc. with more clarity.
|
| |
|
|
| |
Make it simpler, and use wcstring instead of wcsdup
|
| | |
|
| |
|
|
|
|
| |
When an error occurs midway through a token, like abc(def,
make the caret point at the location of the error (i.e. the paren)
instead of at the beginning of the token.
|
| |\
| |
| |
| | |
http://include-what-you-use.org/
|
| | |
| |
| |
| | |
Migrate some functions into tokenizer instance methods
|
| | | |
|
| | | |
|
| |/ |
|
|
|
This change moves source files into a src/ directory,
and puts object files into an obj/ directory. The Makefile
and xcode project are updated accordingly.
Fixes #1866
|
Aaron Gyes
Kurtis Rader
David Adam
ridiculousfish
Jak Wings