aboutsummaryrefslogtreecommitdiffhomepage
path: root/exec.cpp
Commit message (Collapse)AuthorAge
* Ignore user-supplied fd redirections above 2 for builtinsGravatar ridiculousfish2015-01-08
| | | | | Prevents e.g. specifying an fd which corresponds to the history file as the stdin for builtin_source
* Rework file descriptor handlingGravatar ridiculousfish2015-01-07
| | | | | | | | Remove global array of file descriptors, in favor of relying on CLO_EXEC exclusively. Also correctly implement "pipe avoidance" so that fd redirections do not conflict with pipes.
* Add more expository comments to eval, and remove a useless parameterGravatar ridiculousfish2015-01-07
|
* Eliminate wcsv2strvGravatar ridiculousfish2014-10-30
|
* Add an assertion to reflect unreachable codeGravatar ridiculousfish2014-10-19
|
* Add new `functions` flag -V/--inherit-variableGravatar Kevin Ballard2014-10-02
| | | | | | | | | | --inherit-variable takes a variable name and snapshots its current value. When the function is executed, it will have a local variable with this value already defined. Printing the function source will include synthesized `set -l` lines for the values. This is primarily useful for functions that are created on the fly, such as in `psub`.
* Base `status -b` off the parser execution stackGravatar Kevin Ballard2014-09-30
| | | | | | | | | | | Instead of globally marking the state as "in block" when evaluating blocks/functions, update the "in block" status when pushing/popping blocks on the parser stack. Fixes #1729. On a side note, `status -b` is actually pretty useless, because it always returns 0 inside of a function (even without this patch).
* Expunge INTERNAL_BLOCK from the codebaseGravatar Kevin Ballard2014-09-30
| | | | It's a relic of the old parser, and isn't used anymore.
* Don't leave is_block in bad state after bad redirectionGravatar Kevin Ballard2014-09-30
| | | | Fixes #1728.
* Remove INTERNAL_BUFFER, which was only used by fish_pagerGravatar ridiculousfish2014-09-22
|
* Decrement SHLVL when running `exec`Gravatar Kevin Ballard2014-09-19
| | | | | | | | | | | `exec` removes fish from the shell "stack", so SHLVL needs to be decremented to match. This means `exec fish` will result in the same SHLVL in the new fish instance. Also tweak the SHLVL logic to interpret an environment SHLVL of "3foo" as garbage instead of as the value "3". Fixes #1693.
* Trim trailing newline on cmdsubst when IFS=''Gravatar Kevin Ballard2014-08-29
| | | | | | | When $IFS is empty, command substitution no longer splits on newlines. However we still want to trim off a single trailing newline, as most commands will emit a trailing newline and it makes it harder to work with their output.
* Clean up the IFS handling in command substitutionGravatar Kevin Ballard2014-08-21
| | | | | | Remove the useless ASCII test of the first byte of IFS. We don't split on the first character, we only use a non-empty IFS as a signal to split on newlines.
* Teach while loops to not hang forever with no-executeGravatar ridiculousfish2014-07-11
| | | | Fixes #1543
* Remove the close_old field from io_fd_t, which is never actuallyGravatar ridiculousfish2014-04-16
| | | | | respected - a bug dating back to fish 1.x! The fd that would be closed is actually closed in io_cleanup_fds().
* Eliminate the parser_use_ast switch, which does nothing, andGravatar ridiculousfish2014-04-14
| | | | exec_no_exec, which also does nothing in the new parser
* Minor cleanup of redirection functionsGravatar ridiculousfish2014-04-11
|
* Fix line number reporting in new parserGravatar ridiculousfish2014-03-20
|
* Remove support for input IO_BUFFERs, which were only used by fish_pagerGravatar ridiculousfish2014-03-15
|
* Revert "Merge pull request #1317 from pullreq/cpp"Gravatar ridiculousfish2014-02-28
| | | | | | | This reverts commit 74135c0600d5dcc40d396d0e7293c17b8d4bdaa7, reversing changes made to 6d749789ce240a3e6f1447777db63fd8e7525560. See discussion in #1317
* Fixes .c -> .cpp in comments. For doxygen.Gravatar Geoff Nixon2014-02-27
|
* Update style and formatting to conform to fish style guide.Gravatar ridiculousfish2014-01-15
|
* Fix some warningsGravatar ridiculousfish2014-01-01
|
* Support for implicit cd, no-exec, and the exit builtin. All tests nowGravatar ridiculousfish2013-12-29
| | | | pass (!). Error reporting still unsteady.
* Fix issues related to redirections and block level IO with new parserGravatar ridiculousfish2013-12-28
|
* Bringup of function definitions, switch statements with new parserGravatar ridiculousfish2013-12-27
|
* Hook up for statements, if statements, and function definition in newGravatar ridiculousfish2013-12-27
| | | | parser
* Refactor block_t storage in parser_t from a linked list to a vectorGravatar ridiculousfish2013-12-20
|
* Cast size_t to unsigned long.Gravatar Konrad Borowski2013-11-25
| | | | | | printf expects unsigned long (%lu) argument, however, size_t doesn't have to be declared as such. As %zu is C99 (but not C++), it shouldn't be used directly. Instead, I have to cast value to the correct type.
* Fix formattingGravatar ridiculousfish2013-10-26
|
* Fix a C++11 compile error with clang.Gravatar ridiculousfish2013-08-25
| | | | https://github.com/mxcl/homebrew/pull/22016#issuecomment-23222977
* Put read pipe last so that eval works again. Addresses ↵Gravatar ridiculousfish2013-08-21
| | | | https://github.com/fish-shell/fish-shell/issues/966
* Replace some #warnings with a comment explaining why the code is OKGravatar ridiculousfish2013-08-19
|
* Big fat refactoring of how redirections work. In fish 1.x and 2.0.0, the ↵Gravatar ridiculousfish2013-08-19
| | | | | | | | | | redirections for a process were flattened into a big list associated with the job, so there was no way to tell which redirections applied to each process. Each process therefore got all the redirections associated with the job. See https://github.com/fish-shell/fish-shell/issues/877 for how this could manifest. With this change, jobs only track their block-level redirections. Process level redirections are correctly associated with the process, and at exec time we stitch them together (block, pipe, and process redirects). This fixes the weird issues where redirects bleed across pipelines (like #877), and also allows us to play with the order in which redirections are applied, since the final list is constructed right before it's needed. This lets us put pipes after block level redirections but before process level redirections, so that a 2>&1-type redirection gets picked up after the pipe, i.e. it should fix https://github.com/fish-shell/fish-shell/issues/110 This is a significant change. The tests all pass. Cross your fingers.
* Initial work towards various IO cleanups with an eye to fixing ↵Gravatar ridiculousfish2013-08-19
| | | | https://github.com/fish-shell/fish-shell/issues/110
* Cleanup of code that decides whether or not to fork. Fix for issue where ↵Gravatar ridiculousfish2013-06-16
| | | | stderr may be output twice.
* Fix for incorrect use of shared ptr referencesGravatar ridiculousfish2013-06-16
|
* Formatting and style updatesGravatar ridiculousfish2013-05-05
|
* Mark stdin as nonblocking if we get EWOULDBLOCK, and before handing it off ↵Gravatar ridiculousfish2013-04-07
| | | | | | to child processes when either starting them or moving them to the foreground. https://github.com/fish-shell/fish-shell/issues/176
* Teach fish how to push and pop blocks even in the face of no_exec. All tests ↵Gravatar ridiculousfish2013-03-25
| | | | | | finally pass. https://github.com/fish-shell/fish-shell/issues/624
* Additional changes related to https://github.com/fish-shell/fish-shell/pull/592Gravatar ridiculousfish2013-02-28
|
* Cleanup and simplify null_terminated_array_t and its clientsGravatar ridiculousfish2013-02-22
|
* Hopeful fix to avoid forking for certain builtins like echo when they have ↵Gravatar ridiculousfish2013-02-22
| | | | an input redirection only
* Fix a crash when redirecting a nonexistent file to a functionGravatar ridiculousfish2013-02-20
| | | | https://github.com/fish-shell/fish-shell/pull/574
* More cleanup based on static analysisGravatar ridiculousfish2013-02-16
| | | | https://github.com/fish-shell/fish-shell/issues/575
* exec(): Fix a stupid crash. Remove commented debug code that became invalidated.Gravatar Cheer Xiao2013-02-11
|
* In exec(), only add and remove pipe_{read,write} when necessaryGravatar Cheer Xiao2013-02-11
|
* Make io_data_t::fd constGravatar Cheer Xiao2013-02-11
| | | | In exec(), pipe_{write,read} no longer get reused.
* remove __warn_unused attribute from exec_subshellGravatar Jan Kanis2013-02-06
|
* Make subcommands modify $status, and make builtin_set not modify status ↵Gravatar ridiculousfish2013-01-31
| | | | | | | unless it fails https://github.com/fish-shell/fish-shell/issues/547 https://github.com/fish-shell/fish-shell/issues/214