| Commit message (Collapse) | Author | Age |
| |
|
|
|
|
|
| |
Now the next line appears immediately after the cancelled line,
without an intervening newline
|
| |
|
|
|
|
|
| |
Previously the .cpp files were #included by common.cpp
Now they get compiled separately
|
|
|
|
|
|
|
|
|
|
|
| |
fish_title currently outputs some escaped text, which can confuse
the line driver (#2453). Issue a carriage return so the line driver
knows we are at the beginning of the line, unless we are writing
the title as part of the prompt. In that case, we may have text from
the previous command still on the line and we don't want to move the
cursor.
Fixes #2453
|
|
|
|
| |
Add missing files to link phase
|
|
|
| |
`git --help` is a valid command and fish should complete it as such
|
|
|
|
|
|
| |
In my rush to get the fix for the wrong default Vi mode escape delay merged
(commit 3e24ae80b3739ded7d4066349fc87d13f2b70727) I neglected to update the
unit test. This change corrects that oversight.
|
|
|
|
|
|
|
| |
Also, correct the Vi mode default escape timeout. I intended it to be 100 ms
in my previous change but it ended up 10 ms which is far too short. A 10 ms
delay will continue to cause problems for people running fish inside `screen`,
`tmux`, or over high latency connections.
|
|
|
|
|
|
| |
Reduces lint errors from 183 to 126 (-31%). Line count from 2231 to 1787 (-20%).
Another step in resolving issue #2902.
|
|
|
|
|
|
| |
Reduces lint errors from 121 to 59 (-51%). Line count from 1578 to 1290 (-18%).
Another step in resolving issue #2902.
|
|
|
|
|
|
| |
Reduces lint errors from 39 to 30 (-23%). Line count from 915 to 670 (-27%).
Another step in resolving issue #2902.
|
|
|
|
|
|
| |
Reduces lint errors from 121 to 52 (-57%). Line count from 1916 to 1671 (-13%).
Another step in resolving issue #2902.
|
|
|
|
|
|
| |
Reduces lint errors from 90 to 72 (-20%). Line count from 1719 to 1298 (-24%).
Another step in resolving issue #2902.
|
| |
|
|
|
|
|
|
|
| |
Not all distros have a `realpath` command. Provide a function that uses the
real command if available else use the fish builtin.
Fixes #2932
|
| |
|
|
|
|
|
|
|
| |
set-upstream was deprecated in git 1.8.0 as stated in [1] in favor
of set-upstream-to. this patch replaces the old flag in fish
completions
[1]: https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/1.8.0.txt
|
|
|
|
|
|
| |
Reduces lint errors from 194 to 142 (-27%). Line count from 3352 to 2645 (-21%).
Another step in resolving issue #2902.
|
|
|
|
|
|
| |
Reduces lint errors from 16 to 14 (-13%). Line count from 558 to 463 (-17%).
Another step in resolving issue #2902.
|
|
|
|
|
|
|
| |
Don't `#include "*.cpp"` modules in other cpp modules. I already took care
of all the builtin_*.cpp modules in my previous change where I restyled
the builtin code. This change fixes the two remaining instances of this
anti-pattern.
|
|
|
|
|
|
| |
Closes #2955.
(cherry picked from commit d5797c543982a0fbc8201ae21db5009e9447f75d)
|
|
|
|
|
|
|
|
|
| |
- More accurate
- Fast enough to be usable (previously, this would sometimes take a few
seconds)
- A bit smaller
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the IWYU cleanup has been merged compile all, not just a couple, of
the builtin modules independent of builtin.cpp. That is, no longer `#include
builtin_NAME.cpp` in builtin.cpp. This is more consistent, more in line with
what developers expect, and is likely to reduce mistakes.
Reduces lint errors from 384 to 336 (-13%). Line count from 6307 to 4988 (-21%).
Another step in resolving issue #2902.
|
|
|
|
|
|
|
| |
- Set PCRE2_SUBSTITUTE_OVERFLOW_LENGTH to get the required buffer length
from pcre2 instead of guessing
- Set PCRE2_SUBSTITUTE_EXTENDED to enable extra goodies in the
replacement string
|
| |
|
|
|
|
|
|
|
|
|
| |
Remove the "make iwyu" build target. Move the functionality into the
recently introduced lint.fish script. Fix a lot, but not all, of the
include-what-you-use errors. Specifically, it fixes all of the IWYU errors
on my OS X server but only removes some of them on my Ubuntu 14.04 server.
Fixes #2957
|
|
|
|
| |
As always, we default to setting globally.
|
|
|
|
| |
This wasn't actually used anywhere.
|
|
|
|
|
| |
Without this, the interactive tests fail when they receive a mode_prompt
in vi-mode.
|
|
|
|
| |
This should fix the tests.
|
|
|
|
|
| |
This was never mentioned in the documentation as the way to switch to
vi-mode, and now does nothing of value anymore.
|
|
|
|
|
| |
This ensures they can just be called and "the right thing" will happen -
fish_user_key_bindings will be executed, the variable will reflect the bindings.
|
|
|
|
|
|
|
| |
This makes fish_mode_prompt rely on $fish_key_bindings instead.
fish_bind_mode is also set in default mode (only always "default"), so
it can't be used as the indicator.
|
|
|
|
|
|
| |
I noticed that Doxygen was also complaining about the "<asis>" and "<bs>"
tags. So convert those to the backslash form like we did for "<outp>" in the
previous commit.
|
|
|
|
|
|
|
|
|
|
| |
Doxygen has been warning that `<outp>` and `</outp>` are not valid XML/HTML commands since commit cb6d5d76 on 20016-04-04. That's primarily because there is at present no way to tell Doxygen to recognize new XML/HTML tags. The actual errors look like this:
```
.../string.doxygen:187: warning: Unsupported xml/html tag </outp> found
```
I hate build errors since they a) cause needless concern, and b) make it harder to notice when I've introduced a new error. So switch from XML/C## style markup to Doxygen style markup for the "outp" annotation.
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
Fixes #2375
|
|
|
|
|
|
| |
The OS X Xcode IDE has a weird requirement that block comments preceding a
function or class definition must begin with three slashes rather than two if
you want the comment displayed in the "Quick Help" window.
|
|\
| |
| |
| |
| |
| | |
Merge the pcre2 10.20 to 10.21 update.
Closes #2943.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Reduces lint errors from 38 to 19 (-50%). Line count from 506 to 426 (-16%).
Another step in resolving issue #2902.
|
| |
| |
| |
| |
| |
| | |
Reduces lint errors from 271 to 215 (-21%). Line count from 4304 to 3242 (-25%).
Another step in resolving issue #2902.
|
| |
| |
| |
| | |
Point build tools at 10.21
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make the history code conform to the new style guide. Every change was
produced by clang-format (e.g., `make style`) with the exception of
comments which were manually reformatted. That has to be done by hand
since clang-format leaves comments alone other than to reflow comment
lines to get them below the allowed line length.
The total number of lines is reduced by 313 lines (13%) in the two
affected files. Line count is generally a poor metric but in this
case it reflects an increase in information density without a loss in
readability. Furthermore, the standardization of braces, whitespace,
and comment style will make it easier for people to read the code.
This reduces the number of warnings by `make lint` from 168 to 87 (a 48%
decrease). Making it much easier to focus on the substantive lint issues.
Further improvements are possible. For example, many comments are not
very helpful (e.g., they point out the obvious) or provide insufficient
detail. But those are beyond the scope of this change.
This is the first step in resolving issue #2902.
|
| |
| |
| |
| | |
(cherry picked from commit ba1008b75033e9ff8f4ad17fa2de25eed115de5c)
|
| |
| |
| |
| |
| |
| | |
Fixes #2941.
(cherry picked from commit 8558561650995b330a1ae5ee87c592382856cc40)
|