aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/core/test/firebase/firestore/util
diff options
context:
space:
mode:
Diffstat (limited to 'Firestore/core/test/firebase/firestore/util')
-rw-r--r--Firestore/core/test/firebase/firestore/util/CMakeLists.txt5
-rw-r--r--Firestore/core/test/firebase/firestore/util/comparison_test.cc23
-rw-r--r--Firestore/core/test/firebase/firestore/util/log_test.cc2
3 files changed, 18 insertions, 12 deletions
diff --git a/Firestore/core/test/firebase/firestore/util/CMakeLists.txt b/Firestore/core/test/firebase/firestore/util/CMakeLists.txt
index eb5a898..93cca16 100644
--- a/Firestore/core/test/firebase/firestore/util/CMakeLists.txt
+++ b/Firestore/core/test/firebase/firestore/util/CMakeLists.txt
@@ -12,6 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+set(CMAKE_CXX_EXTENSIONS ON)
+
+# Required to allow 0 length printf style strings for testing purposes.
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-format-zero-length")
+
if(HAVE_ARC4RANDOM)
cc_test(
firebase_firestore_util_arc4random_test
diff --git a/Firestore/core/test/firebase/firestore/util/comparison_test.cc b/Firestore/core/test/firebase/firestore/util/comparison_test.cc
index ecbed4a..ccb3011 100644
--- a/Firestore/core/test/firebase/firestore/util/comparison_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/comparison_test.cc
@@ -16,6 +16,7 @@
#include "Firestore/core/src/firebase/firestore/util/comparison.h"
+#include <inttypes.h>
#include <math.h>
#include <limits>
@@ -84,17 +85,17 @@ TEST(Comparison, DoubleCompare) {
ASSERT_SAME(Compare<double>(-0, 0));
}
-#define ASSERT_BIT_EQUALS(expected, actual) \
- do { \
- uint64_t expectedBits = DoubleBits(expected); \
- uint64_t actualBits = DoubleBits(actual); \
- if (expectedBits != actualBits) { \
- std::string message = StringPrintf( \
- "Expected <%f> to compare equal to <%f> " \
- "with bits <%llX> equal to <%llX>", \
- actual, expected, actualBits, expectedBits); \
- FAIL() << message; \
- } \
+#define ASSERT_BIT_EQUALS(expected, actual) \
+ do { \
+ uint64_t expectedBits = DoubleBits(expected); \
+ uint64_t actualBits = DoubleBits(actual); \
+ if (expectedBits != actualBits) { \
+ std::string message = StringPrintf( \
+ "Expected <%f> to compare equal to <%f> " \
+ "with bits <%" PRIu64 "> equal to <%" PRIu64 ">", \
+ actual, expected, actualBits, expectedBits); \
+ FAIL() << message; \
+ } \
} while (0);
#define ASSERT_MIXED_SAME(doubleValue, longValue) \
diff --git a/Firestore/core/test/firebase/firestore/util/log_test.cc b/Firestore/core/test/firebase/firestore/util/log_test.cc
index 46cbc4e..973b174 100644
--- a/Firestore/core/test/firebase/firestore/util/log_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/log_test.cc
@@ -30,7 +30,7 @@ namespace util {
//
// You can fix it with:
//
-// defaults write firebase_firestore_util_log_apple_test \
+// defaults write firebase_firestore_util_log_apple_test
// /google/firebase/debug_mode NO
TEST(Log, SetAndGet) {
LogSetLevel(kLogLevelVerbose);