diff options
| -rw-r--r-- | Firestore/Example/SwiftBuildTest/main.swift | 41 | ||||
| -rw-r--r-- | Firestore/Example/Tests/API/FIRQueryTests.m | 4 | ||||
| -rw-r--r-- | Firestore/Example/Tests/Integration/API/FIRQueryTests.m | 2 |
3 files changed, 27 insertions, 20 deletions
diff --git a/Firestore/Example/SwiftBuildTest/main.swift b/Firestore/Example/SwiftBuildTest/main.swift index f62bf48..260735b 100644 --- a/Firestore/Example/SwiftBuildTest/main.swift +++ b/Firestore/Example/SwiftBuildTest/main.swift @@ -39,7 +39,7 @@ func main() { listenToDocuments(matching: query); - enableDisableNetwork(db: db); + enableDisableNetwork(database: db); types(); } @@ -133,7 +133,7 @@ func writeDocument(at docRef: DocumentReference) { } } -func enableDisableNetwork(db db: Firestore) { +func enableDisableNetwork(database db: Firestore) { // closure syntax db.disableNetwork(completion: { (error) in if let e = error { @@ -235,26 +235,27 @@ func readDocuments(matching query: Query) { func listenToDocument(at docRef: DocumentReference) { - let listener = docRef.addSnapshotListener() { document, error in - if let error = error { - print("Uh oh! Listen canceled: \(error)") - return - } + let listener = docRef.addSnapshotListener() { document, error in + if let error = error { + print("Uh oh! Listen canceled: \(error)") + return + } - if let document = document { - // Note that document.data() is nullable. - let data : [String:Any]? = document.data() - print("Current document: \(data)"); - if (document.metadata.isFromCache) { - print("From Cache") - } else { - print("From Server") - } - } + if let document = document { + // Note that document.data() is nullable. + if let data : [String:Any] = document.data() { + print("Current document: \(data)"); + } + if document.metadata.isFromCache { + print("From Cache") + } else { + print("From Server") + } } + } - // Unsubscribe. - listener.remove(); + // Unsubscribe. + listener.remove(); } func listenToDocuments(matching query: Query) { @@ -316,7 +317,7 @@ func transactions() { let balanceA = try transaction.getDocument(accA)["balance"] as! Double let balanceB = try transaction.getDocument(accB)["balance"] as! Double - if (balanceA < amount) { + if balanceA < amount { errorPointer?.pointee = NSError(domain: "Foo", code: 123, userInfo: nil) return nil } diff --git a/Firestore/Example/Tests/API/FIRQueryTests.m b/Firestore/Example/Tests/API/FIRQueryTests.m index 366a6bf..cac9f2a 100644 --- a/Firestore/Example/Tests/API/FIRQueryTests.m +++ b/Firestore/Example/Tests/API/FIRQueryTests.m @@ -33,6 +33,8 @@ NS_ASSUME_NONNULL_BEGIN @implementation FIRQueryTests - (void)testFilteringWithPredicate { +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wnonnull" // Everything is dummy for unit test here. Filtering does not require any app // specific setting as far as we do not fetch data. FIRFirestore *firestore = [[FIRFirestore alloc] initWithProjectID:@"abc" @@ -41,6 +43,8 @@ NS_ASSUME_NONNULL_BEGIN credentialsProvider:nil workerDispatchQueue:nil firebaseApp:nil]; +#pragma clang diagnostic pop + FSTResourcePath *path = [FSTResourcePath pathWithString:@"foo"]; FIRQuery *query = [FIRQuery referenceWithQuery:[FSTQuery queryWithPath:path] firestore:firestore]; FIRQuery *query1 = [query queryWhereField:@"f" isLessThanOrEqualTo:@1]; diff --git a/Firestore/Example/Tests/Integration/API/FIRQueryTests.m b/Firestore/Example/Tests/Integration/API/FIRQueryTests.m index 251270a..831c897 100644 --- a/Firestore/Example/Tests/Integration/API/FIRQueryTests.m +++ b/Firestore/Example/Tests/Integration/API/FIRQueryTests.m @@ -271,6 +271,8 @@ [self enableNetwork]; querySnap = [self.eventAccumulator awaitEventWithName:@"back online event with isFromCache=NO"]; XCTAssertEqual(querySnap.metadata.isFromCache, NO); + + [registration remove]; } @end |