diff options
| author |  Gil <mcg@google.com> | 2018-03-29 13:23:41 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-03-29 13:23:41 -0700 |
| commit | 45e68a352d4ceb2e2646170bf134ea22f46bc513 (patch) | |
| tree | edf80dce5fec678d9266c0e8db20dfee00ad3512 /scripts | |
| parent | 861ad89de920553ed4f25a4754ee986c9aec9162 (diff) | |
Clean up usages of std::make_unique that crept in (#996)
* Add std::make_unique rule
* Clean up usages of std::make_unique that crept in
This fails to build under Xcode 8.2
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/cpplint.py | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/scripts/cpplint.py b/scripts/cpplint.py index 53dbe81..d1c80b3 100644 --- a/scripts/cpplint.py +++ b/scripts/cpplint.py @@ -5875,6 +5875,16 @@ def FlagCxx14Features(filename, clean_lines, linenum, error): error(filename, linenum, 'build/c++14', 5, ('<%s> is an unapproved C++14 header.') % include.group(1)) + # These are classes and free functions with abeil equivalents + for top_name in ( + # memory + 'make_unique', + ): + if Search(r'\bstd::%s\b' % top_name, line): + error(filename, linenum, 'build/c++14', 5, + 'std::%s does not exist in C++11. Use absl::%s instead.' % + (top_name, top_name)) + def ProcessFileData(filename, file_extension, lines, error, extra_check_functions=[]): @@ -5913,6 +5923,7 @@ def ProcessFileData(filename, file_extension, lines, error, include_state, function_state, nesting_state, error, extra_check_functions) FlagCxx11Features(filename, clean_lines, line, error) + FlagCxx14Features(filename, clean_lines, line, error) nesting_state.CheckCompletedBlocks(filename, error) CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error) |