diff options
| author |  Gil <mcg@google.com> | 2018-01-08 08:57:36 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-01-08 08:57:36 -0800 |
| commit | 0f6103e4048242aa066b4ae0e0473578b50b559c (patch) | |
| tree | 7f5e450db0a866f29a5bd0e64f7a40e6a264825e /cmake/external/firestore.cmake | |
| parent | bc74670afec651c3f912cb6b7e54f5b68bd507f5 (diff) | |
Port StringPrintf from //base (#624)
* Port StringPrintf from //base.
Prefer this to approaches based on variadic templates. While the variadic
template mechanisms are strictly safer, they result in binary bloat we
can't afford.
This is essentially the same StringPrintf previously open sourced as a
part of protobuf, though updated for C++11 which saves a copy and a
temporary buffer on the heap.
* Add abseil as a subdirectory of Firestore
This saves having to redefine all the libraries that abseil defines as
imported libraries.
* Rename firebase_firesture_util_log_* targets
Cut the log out of the name to reflect that these will get more
components besides just logging.
Diffstat (limited to 'cmake/external/firestore.cmake')
| -rw-r--r-- | cmake/external/firestore.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmake/external/firestore.cmake b/cmake/external/firestore.cmake index 61f79f3..1abb629 100644 --- a/cmake/external/firestore.cmake +++ b/cmake/external/firestore.cmake @@ -19,7 +19,7 @@ set(binary_dir ${PROJECT_BINARY_DIR}/Firestore) ExternalProject_Add( Firestore - DEPENDS abseil-cpp FirebaseCore googletest leveldb + DEPENDS FirebaseCore googletest leveldb # Lay the binary directory out as if this were a subproject. This makes it # possible to build and test in it directly. |