diff options
| author |  Sebastian Schmidt <mrschmidt@google.com> | 2017-10-06 09:48:03 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-10-06 09:48:03 -0700 |
| commit | 19d1bb304a758b2d42d7ba611fb73be4c42ff03f (patch) | |
| tree | 967ad1af14c1aa70201363304f61911208e11f47 /Firestore | |
| parent | 202fac501d0c8bfa405e5d7ee90ef52f3560c853 (diff) | |
Adding NS_SWIFT_NAME for FIRListenerRegistration (#339)
Diffstat (limited to 'Firestore')
| -rw-r--r-- | Firestore/CHANGELOG.md | 2 | ||||
| -rw-r--r-- | Firestore/Example/SwiftBuildTest/main.swift | 6 | ||||
| -rw-r--r-- | Firestore/Source/Public/FIRListenerRegistration.h | 3 | ||||
| -rw-r--r-- | Firestore/Source/Public/FIRSetOptions.h | 4 |
4 files changed, 9 insertions, 6 deletions
diff --git a/Firestore/CHANGELOG.md b/Firestore/CHANGELOG.md index 53d222e..089e273 100644 --- a/Firestore/CHANGELOG.md +++ b/Firestore/CHANGELOG.md @@ -1,5 +1,5 @@ # Unreleased -- [fixed] Add an NS_SWIFT_NAME for FIRSnapshotMetadata +- [fixed] Add an NS_SWIFT_NAME for FIRSnapshotMetadata and FIRListenerRegistration # 2017-10-03 -- v0.8.0 - Initial public release. diff --git a/Firestore/Example/SwiftBuildTest/main.swift b/Firestore/Example/SwiftBuildTest/main.swift index 3b8219b..8cc0302 100644 --- a/Firestore/Example/SwiftBuildTest/main.swift +++ b/Firestore/Example/SwiftBuildTest/main.swift @@ -274,10 +274,6 @@ func transactions() { } func types() { - // Just highlighting the types of everything, though devs can/will often omit them. - // This list comes from: - // - // grep -r ^FIR_SWIFT_NAME Firestore/Source/Public | sed 's/.*(/let _: /; s/)/;/' let _: CollectionReference; let _: DocumentChange; let _: DocumentListenOptions; @@ -288,9 +284,11 @@ func types() { let _: Firestore; let _: FirestoreSettings; let _: GeoPoint; + let _: ListenerRegistration; let _: QueryListenOptions; let _: Query; let _: QuerySnapshot; + let _: SetOptions; let _: SnapshotMetadata; let _: Transaction; let _: WriteBatch; diff --git a/Firestore/Source/Public/FIRListenerRegistration.h b/Firestore/Source/Public/FIRListenerRegistration.h index 5fe7fd5..93df407 100644 --- a/Firestore/Source/Public/FIRListenerRegistration.h +++ b/Firestore/Source/Public/FIRListenerRegistration.h @@ -16,9 +16,12 @@ #import <Foundation/Foundation.h> +#import "FIRFirestoreSwiftNameSupport.h" + NS_ASSUME_NONNULL_BEGIN /** Represents a listener that can be removed by calling remove. */ +FIR_SWIFT_NAME(ListenerRegistration) @protocol FIRListenerRegistration <NSObject> /** diff --git a/Firestore/Source/Public/FIRSetOptions.h b/Firestore/Source/Public/FIRSetOptions.h index c865e06..e1103a1 100644 --- a/Firestore/Source/Public/FIRSetOptions.h +++ b/Firestore/Source/Public/FIRSetOptions.h @@ -16,6 +16,8 @@ #import <Foundation/Foundation.h> +#import "FIRFirestoreSwiftNameSupport.h" + NS_ASSUME_NONNULL_BEGIN /** @@ -24,7 +26,7 @@ NS_ASSUME_NONNULL_BEGIN * `FIRWriteBatch` and `FIRTransaction` can be configured to perform granular merges instead * of overwriting the target documents in their entirety. */ -NS_SWIFT_NAME(SetOptions) +FIR_SWIFT_NAME(SetOptions) @interface FIRSetOptions : NSObject /** */ |