diff options
| author |  Gil <mcg@google.com> | 2018-01-19 12:27:11 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-01-19 12:27:11 -0800 |
| commit | 39d8252300015c26f1932cff42032613fdb36a09 (patch) | |
| tree | 93bb3ab7c476289c4afe6cf91773a60b6f53a94d /Firestore/third_party | |
| parent | 9f7c094f9f00a6efc0107071f109ef1bc4d7357d (diff) | |
Port comparison to C++ (#678)
This reimplements our comparison functions as C++ Comparators and then provides compatibility shims for interoperating with existing Objective-C usage.
A few specialized comparators aren't suitable for porting but only have a single usage (e.g. CompareBytes for comparing NSData * instances). In these cases I've moved them into the caller.
* Use int32_t for typeof(ID) in FSTDocumentReference
* Migrate callers of FSTComparison.h to Objective-C++
* Port comparison to C++
* Migrate usages of FSTComparison.h to C++ equivalents
* Remove FSTComparison
Diffstat (limited to 'Firestore/third_party')
| -rw-r--r-- | Firestore/third_party/abseil-cpp/absl/base/macros.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Firestore/third_party/abseil-cpp/absl/base/macros.h b/Firestore/third_party/abseil-cpp/absl/base/macros.h index d414087..07c5cf7 100644 --- a/Firestore/third_party/abseil-cpp/absl/base/macros.h +++ b/Firestore/third_party/abseil-cpp/absl/base/macros.h @@ -196,7 +196,7 @@ enum LinkerInitialized { #define ABSL_ASSERT(expr) (false ? (void)(expr) : (void)0) #else #define ABSL_ASSERT(expr) \ - (ABSL_PREDICT_TRUE((expr)) ? (void)0 : [] { assert(false && #expr); }()) + (void) (ABSL_PREDICT_TRUE((expr)) ? (void)0 : [] { assert(false && #expr); }()) #endif #endif // ABSL_BASE_MACROS_H_ |