Add missing tests to the Firestore project (#1254)

* Fix order of project elements

* Add immutable container tests to the Firestore project

* Fix style problems in TransformOperations

  * Method names should have an initial upper case character (except
    getters/setters)
  * Pointers bind to the type not the name in C++
  * Fix unsigned/signed comparison warning

* Make transform_operations.h Objective-C++ only

It turns out that you can't conditionally define virtual methods. This
causes multiple versions of the vtable to be emitted and when the linker
resolves all the vtable definitions for a class it picks one arbitrarily
causing failures for callers that expect some of the conditional methods
to be present.

* Add precondition_test and field_mask_test to the project

* Add field_transform_test and transform_operations_test to the project

* Clean up missing newline/excess comments

* Use braced initialization to avoid linter false positive on std::transform

3 files changed, 0 insertions, 95 deletions

diff --git a/Firestore/core/test/firebase/firestore/model/CMakeLists.txt b/Firestore/core/test/firebase/firestore/model/CMakeLists.txt
index 9c94677..b38d658 100644
--- a/Firestore/core/test/firebase/firestore/model/CMakeLists.txt
+++ b/Firestore/core/test/firebase/firestore/model/CMakeLists.txt
@@ -20,14 +20,12 @@ cc_test(
     document_test.cc
     field_mask_test.cc
     field_path_test.cc
-    field_transform_test.cc
     field_value_test.cc
     maybe_document_test.cc
     no_document_test.cc
     precondition_test.cc
     resource_path_test.cc
     snapshot_version_test.cc
-    transform_operations_test.cc
   DEPENDS
     firebase_firestore_model
 )
diff --git a/Firestore/core/test/firebase/firestore/model/field_transform_test.cc b/Firestore/core/test/firebase/firestore/model/field_transform_test.cc
deleted file mode 100644
index b66aeef..0000000
--- a/Firestore/core/test/firebase/firestore/model/field_transform_test.cc
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Copyright 2018 Google
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "Firestore/core/src/firebase/firestore/model/field_transform.h"
-#include "Firestore/core/src/firebase/firestore/model/transform_operations.h"
-#include "Firestore/core/test/firebase/firestore/testutil/testutil.h"
-
-#include "absl/memory/memory.h"
-#include "gtest/gtest.h"
-
-namespace firebase {
-namespace firestore {
-namespace model {
-
-TEST(FieldTransform, Getter) {
-  FieldTransform transform(testutil::Field("foo"),
-                           absl::make_unique<ServerTimestampTransform>(
-                               ServerTimestampTransform::Get()));
-
-  EXPECT_EQ(testutil::Field("foo"), transform.path());
-  EXPECT_EQ(ServerTimestampTransform::Get(), transform.transformation());
-}
-
-}  // namespace model
-}  // namespace firestore
-}  // namespace firebase
diff --git a/Firestore/core/test/firebase/firestore/model/transform_operations_test.cc b/Firestore/core/test/firebase/firestore/model/transform_operations_test.cc
deleted file mode 100644
index ec0882a..0000000
--- a/Firestore/core/test/firebase/firestore/model/transform_operations_test.cc
+++ /dev/null
@@ -1,54 +0,0 @@
-/*
- * Copyright 2018 Google
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "Firestore/core/src/firebase/firestore/model/transform_operations.h"
-
-#include "gtest/gtest.h"
-
-namespace firebase {
-namespace firestore {
-namespace model {
-
-class DummyOperation : public TransformOperation {
- public:
-  DummyOperation() {
-  }
-
-  Type type() const override {
-    return Type::Test;
-  }
-
-  bool operator==(const TransformOperation& other) const override {
-    return this == &other;
-  }
-};
-
-TEST(TransformOperations, ServerTimestamp) {
-  ServerTimestampTransform transform = ServerTimestampTransform::Get();
-  EXPECT_EQ(TransformOperation::Type::ServerTimestamp, transform.type());
-
-  ServerTimestampTransform another = ServerTimestampTransform::Get();
-  DummyOperation dummy;
-  EXPECT_EQ(transform, another);
-  EXPECT_NE(transform, dummy);
-}
-
-// TODO(mikelehen): Add ArrayTransform test once it no longer depends on
-// FSTFieldValue and can be exposed to C++ code.
-
-}  // namespace model
-}  // namespace firestore
-}  // namespace firebase