aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/core/test
diff options
context:
space:
mode:
authorGravatar rsgowman <rgowman@google.com>2018-04-05 12:02:15 -0400
committerGravatar GitHub <noreply@github.com>2018-04-05 12:02:15 -0400
commit73d3f78ada04719b6aacba63b58e8284a4045d98 (patch)
tree6377f4b06bfd821ad73075ab8caac9444fc7b502 /Firestore/core/test
parentdb717bf6704b444b093d46f53935402c83441854 (diff)
Add error handling for serializer (for serializing case only) (#991)
Deserializing not handled yet. Note that the serializing case is fairly uninteresting, as assuming valid input is passed in, there's no real reason why it should fail (and if it does fail, it indicates a gross violation of our understanding of the system.)
Diffstat (limited to 'Firestore/core/test')
-rw-r--r--Firestore/core/test/firebase/firestore/remote/serializer_test.cc5
1 files changed, 4 insertions, 1 deletions
diff --git a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
index 862ac97..947c2fe 100644
--- a/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
+++ b/Firestore/core/test/firebase/firestore/remote/serializer_test.cc
@@ -42,10 +42,12 @@
#include <vector>
#include "Firestore/core/src/firebase/firestore/model/field_value.h"
+#include "Firestore/core/src/firebase/firestore/util/status.h"
#include "gtest/gtest.h"
using firebase::firestore::model::FieldValue;
using firebase::firestore::remote::Serializer;
+using firebase::firestore::util::Status;
TEST(Serializer, CanLinkToNanopb) {
// This test doesn't actually do anything interesting as far as actually using
@@ -67,7 +69,8 @@ class SerializerTest : public ::testing::Test {
FieldValue::Type type) {
EXPECT_EQ(type, model.type());
std::vector<uint8_t> actual_bytes;
- serializer.EncodeFieldValue(model, &actual_bytes);
+ Status status = serializer.EncodeFieldValue(model, &actual_bytes);
+ EXPECT_TRUE(status.ok());
EXPECT_EQ(bytes, actual_bytes);
FieldValue actual_model = serializer.DecodeFieldValue(bytes);
EXPECT_EQ(type, actual_model.type());