diff options
author | Gil <mcg@google.com> | 2018-04-09 11:54:39 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-09 11:54:39 -0700 |
commit | 0a6618705389543191a8c44278d4c6791c84602a (patch) | |
tree | 4f195f31da90b29ffa5219e016b2cfd9ad0a7ccf /Firestore/core/test/firebase/firestore | |
parent | 2f2bb7f4c717bb95df69735e93ae84de8b8feaad (diff) |
Add lint checking for Objective-C++ sources (#1048)
* lint.sh now lints Objective-C++ too
* cpplint checks system-style includes that should be user-style
This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.
* cpplint checks #imports and #includes
* cpplint checks that C++ system headers aren't #imported
* cpplint checks for C system headers that could be C++ system headers
* cpplint checks that Objective-C sources include their headers
Diffstat (limited to 'Firestore/core/test/firebase/firestore')
7 files changed, 11 insertions, 12 deletions
diff --git a/Firestore/core/test/firebase/firestore/model/field_value_test.cc b/Firestore/core/test/firebase/firestore/model/field_value_test.cc index 40be2d5..08db76d 100644 --- a/Firestore/core/test/firebase/firestore/model/field_value_test.cc +++ b/Firestore/core/test/firebase/firestore/model/field_value_test.cc @@ -16,8 +16,7 @@ #include "Firestore/core/src/firebase/firestore/model/field_value.h" -#include <limits.h> - +#include <climits> #include <vector> #include "gtest/gtest.h" diff --git a/Firestore/core/test/firebase/firestore/remote/datastore_test.cc b/Firestore/core/test/firebase/firestore/remote/datastore_test.cc index 42a9a8c..53e95a9 100644 --- a/Firestore/core/test/firebase/firestore/remote/datastore_test.cc +++ b/Firestore/core/test/firebase/firestore/remote/datastore_test.cc @@ -16,8 +16,9 @@ #include "Firestore/core/src/firebase/firestore/remote/datastore.h" -#include <grpc/grpc.h> -#include <gtest/gtest.h> +#include "grpc/grpc.h" + +#include "gtest/gtest.h" TEST(Datastore, CanLinkToGrpc) { // This test doesn't actually do anything interesting as far as actually diff --git a/Firestore/core/test/firebase/firestore/util/autoid_test.cc b/Firestore/core/test/firebase/firestore/util/autoid_test.cc index 079b990..808850b 100644 --- a/Firestore/core/test/firebase/firestore/util/autoid_test.cc +++ b/Firestore/core/test/firebase/firestore/util/autoid_test.cc @@ -16,9 +16,9 @@ #include "Firestore/core/src/firebase/firestore/util/autoid.h" -#include <ctype.h> +#include <cctype> -#include <gtest/gtest.h> +#include "gtest/gtest.h" using firebase::firestore::util::CreateAutoId; diff --git a/Firestore/core/test/firebase/firestore/util/comparison_test.cc b/Firestore/core/test/firebase/firestore/util/comparison_test.cc index ccb3011..a03aec8 100644 --- a/Firestore/core/test/firebase/firestore/util/comparison_test.cc +++ b/Firestore/core/test/firebase/firestore/util/comparison_test.cc @@ -16,9 +16,8 @@ #include "Firestore/core/src/firebase/firestore/util/comparison.h" -#include <inttypes.h> -#include <math.h> - +#include <cinttypes> +#include <cmath> #include <limits> #include "Firestore/core/src/firebase/firestore/util/string_printf.h" diff --git a/Firestore/core/test/firebase/firestore/util/secure_random_test.cc b/Firestore/core/test/firebase/firestore/util/secure_random_test.cc index 0b7a51b..b0dfdd6 100644 --- a/Firestore/core/test/firebase/firestore/util/secure_random_test.cc +++ b/Firestore/core/test/firebase/firestore/util/secure_random_test.cc @@ -16,7 +16,7 @@ #include "Firestore/core/src/firebase/firestore/util/secure_random.h" -#include <gtest/gtest.h> +#include "gtest/gtest.h" using firebase::firestore::util::SecureRandom; diff --git a/Firestore/core/test/firebase/firestore/util/string_printf_test.cc b/Firestore/core/test/firebase/firestore/util/string_printf_test.cc index 085be84..14cc9c8 100644 --- a/Firestore/core/test/firebase/firestore/util/string_printf_test.cc +++ b/Firestore/core/test/firebase/firestore/util/string_printf_test.cc @@ -16,7 +16,7 @@ #include "Firestore/core/src/firebase/firestore/util/string_printf.h" -#include <gtest/gtest.h> +#include "gtest/gtest.h" namespace firebase { namespace firestore { diff --git a/Firestore/core/test/firebase/firestore/util/string_util_test.cc b/Firestore/core/test/firebase/firestore/util/string_util_test.cc index f94596f..a85c849 100644 --- a/Firestore/core/test/firebase/firestore/util/string_util_test.cc +++ b/Firestore/core/test/firebase/firestore/util/string_util_test.cc @@ -16,7 +16,7 @@ #include "Firestore/core/src/firebase/firestore/util/string_util.h" -#include <gtest/gtest.h> +#include "gtest/gtest.h" namespace firebase { namespace firestore { |