Reimplement C++ logging (#1313)

* Add direct support for formatting Objective-C objects
* Rewrite log.h
* Convert FSTWarn to LOG_WARN
* Convert FSTLog to LOG_DEBUG
* Remove FSTLogger

1 files changed, 6 insertions, 14 deletions

diff --git a/Firestore/core/test/firebase/firestore/util/log_test.cc b/Firestore/core/test/firebase/firestore/util/log_test.cc
index 973b174..73050ea 100644
--- a/Firestore/core/test/firebase/firestore/util/log_test.cc
+++ b/Firestore/core/test/firebase/firestore/util/log_test.cc
@@ -33,27 +33,19 @@ namespace util {
 //   defaults write firebase_firestore_util_log_apple_test
 //       /google/firebase/debug_mode NO
 TEST(Log, SetAndGet) {
-  LogSetLevel(kLogLevelVerbose);
+  EXPECT_FALSE(LogIsDebugEnabled());
 
   LogSetLevel(kLogLevelDebug);
-  EXPECT_EQ(kLogLevelDebug, LogGetLevel());
-
-  LogSetLevel(kLogLevelInfo);
-  EXPECT_EQ(kLogLevelInfo, LogGetLevel());
+  EXPECT_TRUE(LogIsDebugEnabled());
 
   LogSetLevel(kLogLevelWarning);
-  EXPECT_EQ(kLogLevelWarning, LogGetLevel());
-
-  LogSetLevel(kLogLevelError);
-  EXPECT_EQ(kLogLevelError, LogGetLevel());
+  EXPECT_FALSE(LogIsDebugEnabled());
 }
 
 TEST(Log, LogAllKinds) {
-  LogDebug("test debug logging %d", 1);
-  LogInfo("test info logging %d", 2);
-  LogWarning("test warning logging %d", 3);
-  LogError("test error logging %d", 4);
-  LogMessage(kLogLevelError, "test va-args %s %c %d", "abc", ':', 123);
+  LOG_DEBUG("test debug logging %s", 1);
+  LOG_WARN("test warning logging %s", 3);
+  LOG_DEBUG("test va-args %s %s %s", "abc", std::string{"def"}, 123);
 }
 
 }  //  namespace util