diff options
| author |  rsgowman <rgowman@google.com> | 2018-02-27 14:33:46 -0500 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-02-27 14:33:46 -0500 |
| commit | 1ecf690259c3d8ba6c34d0bd18178129bd2b9344 (patch) | |
| tree | 881f3a50762d9eb130ac82238ce019c8f998d62c /Firestore/core/src/firebase/firestore | |
| parent | 3e7c062f3baca83fae1937bf60865be0cd18f96d (diff) | |
Add FieldValue.boolean_value() (#862)
Diffstat (limited to 'Firestore/core/src/firebase/firestore')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/model/field_value.h | 5 | ||||
| -rw-r--r-- | Firestore/core/src/firebase/firestore/remote/serializer.cc | 7 |
2 files changed, 6 insertions, 6 deletions
diff --git a/Firestore/core/src/firebase/firestore/model/field_value.h b/Firestore/core/src/firebase/firestore/model/field_value.h index 15945b9..72b9481 100644 --- a/Firestore/core/src/firebase/firestore/model/field_value.h +++ b/Firestore/core/src/firebase/firestore/model/field_value.h @@ -96,6 +96,11 @@ class FieldValue { return tag_; } + bool boolean_value() const { + FIREBASE_ASSERT(tag_ == Type::Boolean); + return boolean_value_; + } + int64_t integer_value() const { FIREBASE_ASSERT(tag_ == Type::Integer); return integer_value_; diff --git a/Firestore/core/src/firebase/firestore/remote/serializer.cc b/Firestore/core/src/firebase/firestore/remote/serializer.cc index 02013fa..79ed98d 100644 --- a/Firestore/core/src/firebase/firestore/remote/serializer.cc +++ b/Firestore/core/src/firebase/firestore/remote/serializer.cc @@ -131,12 +131,7 @@ void Serializer::EncodeFieldValue(const FieldValue& field_value, // TODO(rsgowman): figure out error handling abort(); } - if (field_value == FieldValue::TrueValue()) { - EncodeBool(&stream, true); - } else { - FIREBASE_DEV_ASSERT(field_value == FieldValue::FalseValue()); - EncodeBool(&stream, false); - } + EncodeBool(&stream, field_value.boolean_value()); break; case FieldValue::Type::Integer: |