diff options
author | Konstantin Varlamov <var-const@users.noreply.github.com> | 2018-07-10 17:45:16 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-07-10 17:45:16 -0400 |
commit | 6466c35737eff21e9b48c3ce2353d42628f4bb77 (patch) | |
tree | 812f47917bbe834a9e0b490c11265930da1639c8 /Firestore/core/src/firebase/firestore/util | |
parent | 0f0a1dab2d385895fc15968cfee3df07b53c52b9 (diff) |
C++ migration: add a C++ implementation of `FSTExponentialBackoff` (#1465)
This is a pretty close port of `FSTExponentialBackoff`. The changes are pretty minor:
* delay is calculated using <chrono> duration types, not plain numbers, which should be a little more type-safe;
* split a piece of code into a ClampDelay function, because it's reasonably close to std::clamp;
* rephrased the class-level comment to make it clearer that the first attempt always has delay = 0;
* added simple tests (other platforms don't have tests for this).
Also make sure that canceling a DelayedOperation is always valid.
Diffstat (limited to 'Firestore/core/src/firebase/firestore/util')
-rw-r--r-- | Firestore/core/src/firebase/firestore/util/executor.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Firestore/core/src/firebase/firestore/util/executor.h b/Firestore/core/src/firebase/firestore/util/executor.h index df8b0b5..ea67b17 100644 --- a/Firestore/core/src/firebase/firestore/util/executor.h +++ b/Firestore/core/src/firebase/firestore/util/executor.h @@ -38,7 +38,9 @@ class DelayedOperation { // If the operation has not been run yet, cancels the operation. Otherwise, // this function is a no-op. void Cancel() { - cancel_func_(); + if (cancel_func_) { + cancel_func_(); + } } // Internal use only. |