diff options
| author |  Rich Gowman <rgowman@google.com> | 2018-06-12 10:27:17 -0400 |
|---|---|---|
| committer | Rich Gowman <rgowman@google.com> | 2018-06-12 10:27:17 -0400 |
| commit | cf2899a085f7ceca3fad2d1fb5336be25cecd7ff (patch) | |
| tree | 38c835a29fcda279c8dd220781d2b5c726da307f /Firestore/core/src/firebase/firestore/util/string_util.h | |
| parent | 1597765af8c897ab73d21d6d404f8eeede7890b1 (diff) | |
| parent | 9307f4893008f7d6cf9473e906d4c896546c5c8c (diff) | |
Merge remote-tracking branch 'origin/master' into rsgowman/protobuf_cpp
Also "fixed" BadFieldValueTagWithOtherValidTagsPresent test by changing
'false' to 'true'. Details: Depending on the version of nanopb, nanopb
would explicitly encode 'false', which shouldn't be done in proto3. When
it's explicitly encoded, the test worked properly. But when it was
(properly) dropped, the invalid tag is the only field that's actually
encoded, thus violating the assumptions of the test, leading to a test
failure. s/false/true fixes it, as now the boolean_value field is
(properly) encoded regardless of version.
Diffstat (limited to 'Firestore/core/src/firebase/firestore/util/string_util.h')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/util/string_util.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/Firestore/core/src/firebase/firestore/util/string_util.h b/Firestore/core/src/firebase/firestore/util/string_util.h index 96ba0b0..86acc56 100644 --- a/Firestore/core/src/firebase/firestore/util/string_util.h +++ b/Firestore/core/src/firebase/firestore/util/string_util.h @@ -65,11 +65,6 @@ std::string PrefixSuccessor(absl::string_view prefix); */ std::string ImmediateSuccessor(absl::string_view s); -/** - * Returns true if the given value starts with the given prefix. - */ -bool StartsWith(const std::string &value, const std::string &prefix); - } // namespace util } // namespace firestore } // namespace firebase |