aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/core/src/firebase/firestore/model/field_value.cc
diff options
context:
space:
mode:
authorGravatar Gil <mcg@google.com>2018-01-19 13:34:13 -0800
committerGravatar zxu <zxu@google.com>2018-01-19 16:34:13 -0500
commitcd0cbe94d0bcb0f6a64b90b74ab3f7ce126a1a6d (patch)
tree28791dc1e59df45421b4f21f8a60707c96f64b17 /Firestore/core/src/firebase/firestore/model/field_value.cc
parent39d8252300015c26f1932cff42032613fdb36a09 (diff)
Use Comparator in FieldValue. (#686)
Diffstat (limited to 'Firestore/core/src/firebase/firestore/model/field_value.cc')
-rw-r--r--Firestore/core/src/firebase/firestore/model/field_value.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/Firestore/core/src/firebase/firestore/model/field_value.cc b/Firestore/core/src/firebase/firestore/model/field_value.cc
index 45886bf..5583afc 100644
--- a/Firestore/core/src/firebase/firestore/model/field_value.cc
+++ b/Firestore/core/src/firebase/firestore/model/field_value.cc
@@ -21,8 +21,11 @@
#include <utility>
#include <vector>
+#include "Firestore/core/src/firebase/firestore/util/comparison.h"
#include "Firestore/core/src/firebase/firestore/util/firebase_assert.h"
+using firebase::firestore::util::Comparator;
+
namespace firebase {
namespace firestore {
namespace model {
@@ -137,8 +140,7 @@ bool operator<(const FieldValue& lhs, const FieldValue& rhs) {
case Type::Null:
return false;
case Type::Boolean:
- // lhs < rhs iff lhs == false and rhs == true.
- return !lhs.boolean_value_ && rhs.boolean_value_;
+ return Comparator<bool>()(lhs.boolean_value_, rhs.boolean_value_);
case Type::Array:
return lhs.array_value_ < rhs.array_value_;
default: