diff options
| author |  Gil <mcg@google.com> | 2018-04-12 14:54:53 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-12 14:54:53 -0700 |
| commit | 8876622b6fcebc21672bc263666b858b7e152b45 (patch) | |
| tree | 053fe00a20207099c11c1464df25565a5f5cc3c6 /Firestore/core/src/firebase/firestore/local | |
| parent | 1397e4ae72ea3b8d16a9b44ed1235caca47b3d9e (diff) | |
Add clang-tidy checks for Firestore (#1078)
* Add a .clang-tidy configuration for Firestore C++
* Fix clang-tidy warnings
* typedef -> using
* const ref + rvalue ref -> pass by value
* NULL -> nullptr
* remove useless default initializations
* remove useless const value-type parameter declarations (definitions
can still use them)
* use auto instead of repeating types in a cast
* Fix typos
* Address use of static method through instance warnings
* Address use after move warnings
Diffstat (limited to 'Firestore/core/src/firebase/firestore/local')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/local/leveldb_key.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Firestore/core/src/firebase/firestore/local/leveldb_key.cc b/Firestore/core/src/firebase/firestore/local/leveldb_key.cc index 03dbeae..7febe71 100644 --- a/Firestore/core/src/firebase/firestore/local/leveldb_key.cc +++ b/Firestore/core/src/firebase/firestore/local/leveldb_key.cc @@ -373,7 +373,7 @@ DocumentKey Reader::ReadDocumentKey() { } ResourcePath path{std::move(path_segments)}; - if (ok_ && path.size() > 0 && DocumentKey::IsDocumentKey(path)) { + if (ok_ && !path.empty() && DocumentKey::IsDocumentKey(path)) { return DocumentKey{std::move(path)}; } |