diff options
| author |  Gil <mcg@google.com> | 2018-04-09 11:54:39 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-09 11:54:39 -0700 |
| commit | 0a6618705389543191a8c44278d4c6791c84602a (patch) | |
| tree | 4f195f31da90b29ffa5219e016b2cfd9ad0a7ccf /Firestore/core/src/firebase/firestore/local | |
| parent | 2f2bb7f4c717bb95df69735e93ae84de8b8feaad (diff) | |
Add lint checking for Objective-C++ sources (#1048)
* lint.sh now lints Objective-C++ too
* cpplint checks system-style includes that should be user-style
This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.
* cpplint checks #imports and #includes
* cpplint checks that C++ system headers aren't #imported
* cpplint checks for C system headers that could be C++ system headers
* cpplint checks that Objective-C sources include their headers
Diffstat (limited to 'Firestore/core/src/firebase/firestore/local')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/local/leveldb_transaction.cc | 3 | ||||
| -rw-r--r-- | Firestore/core/src/firebase/firestore/local/leveldb_transaction.h | 8 |
2 files changed, 5 insertions, 6 deletions
diff --git a/Firestore/core/src/firebase/firestore/local/leveldb_transaction.cc b/Firestore/core/src/firebase/firestore/local/leveldb_transaction.cc index d84d441..f998550 100644 --- a/Firestore/core/src/firebase/firestore/local/leveldb_transaction.cc +++ b/Firestore/core/src/firebase/firestore/local/leveldb_transaction.cc @@ -16,12 +16,11 @@ #include "Firestore/core/src/firebase/firestore/local/leveldb_transaction.h" -#include <leveldb/write_batch.h> - #include "Firestore/core/src/firebase/firestore/local/leveldb_key.h" #include "Firestore/core/src/firebase/firestore/util/firebase_assert.h" #include "Firestore/core/src/firebase/firestore/util/log.h" #include "absl/memory/memory.h" +#include "leveldb/write_batch.h" using leveldb::DB; using leveldb::ReadOptions; diff --git a/Firestore/core/src/firebase/firestore/local/leveldb_transaction.h b/Firestore/core/src/firebase/firestore/local/leveldb_transaction.h index 56a9a77..a6ddce2 100644 --- a/Firestore/core/src/firebase/firestore/local/leveldb_transaction.h +++ b/Firestore/core/src/firebase/firestore/local/leveldb_transaction.h @@ -17,16 +17,16 @@ #ifndef FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_LOCAL_LEVELDB_TRANSACTION_H_ #define FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_LOCAL_LEVELDB_TRANSACTION_H_ -#include <absl/strings/string_view.h> -#include <leveldb/db.h> - -#include <stdint.h> +#include <cstdint> #include <map> #include <memory> #include <set> #include <string> #include <utility> +#include "absl/strings/string_view.h" +#include "leveldb/db.h" + #if __OBJC__ #import <Protobuf/GPBProtocolBuffers.h> #endif |