diff options
| author |  Gil <mcg@google.com> | 2018-04-12 14:54:53 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-12 14:54:53 -0700 |
| commit | 8876622b6fcebc21672bc263666b858b7e152b45 (patch) | |
| tree | 053fe00a20207099c11c1464df25565a5f5cc3c6 /Firestore/core/src/firebase/firestore/immutable | |
| parent | 1397e4ae72ea3b8d16a9b44ed1235caca47b3d9e (diff) | |
Add clang-tidy checks for Firestore (#1078)
* Add a .clang-tidy configuration for Firestore C++
* Fix clang-tidy warnings
* typedef -> using
* const ref + rvalue ref -> pass by value
* NULL -> nullptr
* remove useless default initializations
* remove useless const value-type parameter declarations (definitions
can still use them)
* use auto instead of repeating types in a cast
* Fix typos
* Address use of static method through instance warnings
* Address use after move warnings
Diffstat (limited to 'Firestore/core/src/firebase/firestore/immutable')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/immutable/array_sorted_map.h | 6 | ||||
| -rw-r--r-- | Firestore/core/src/firebase/firestore/immutable/map_entry.h | 2 |
2 files changed, 3 insertions, 5 deletions
diff --git a/Firestore/core/src/firebase/firestore/immutable/array_sorted_map.h b/Firestore/core/src/firebase/firestore/immutable/array_sorted_map.h index 56da9e9..92fd823 100644 --- a/Firestore/core/src/firebase/firestore/immutable/array_sorted_map.h +++ b/Firestore/core/src/firebase/firestore/immutable/array_sorted_map.h @@ -70,8 +70,8 @@ class FixedArray { */ template <typename SourceIterator> void append(SourceIterator src_begin, SourceIterator src_end) { - size_type appending = static_cast<size_type>(src_end - src_begin); - size_type new_size = size_ + appending; + auto appending = static_cast<size_type>(src_end - src_begin); + auto new_size = size_ + appending; FIREBASE_ASSERT(new_size <= fixed_size); std::copy(src_begin, src_end, end()); @@ -229,8 +229,6 @@ class ArraySortedMap : public SortedMapBase { } } - // TODO(wilhuff): indexof - /** Returns true if the map contains no elements. */ bool empty() const { return size() == 0; diff --git a/Firestore/core/src/firebase/firestore/immutable/map_entry.h b/Firestore/core/src/firebase/firestore/immutable/map_entry.h index 2130b5b..1022b06 100644 --- a/Firestore/core/src/firebase/firestore/immutable/map_entry.h +++ b/Firestore/core/src/firebase/firestore/immutable/map_entry.h @@ -33,7 +33,7 @@ namespace immutable { */ template <typename K, typename V, typename C = std::less<K>> struct KeyComparator { - typedef std::pair<K, V> pair_type; + using pair_type = std::pair<K, V>; explicit KeyComparator(const C& comparator = C()) : key_comparator_(comparator) { |