Port PrimitiveValueTest test for core::Query (#1530)

(From java.)

Also fix a bug uncovered by the test. (oops)

1 files changed, 4 insertions, 2 deletions

diff --git a/Firestore/core/src/firebase/firestore/core/relation_filter.h b/Firestore/core/src/firebase/firestore/core/relation_filter.h
index 94da208..8110ac1 100644
--- a/Firestore/core/src/firebase/firestore/core/relation_filter.h
+++ b/Firestore/core/src/firebase/firestore/core/relation_filter.h
@@ -35,7 +35,9 @@ class RelationFilter : public Filter {
    * Creates a new filter that compares fields and values. Only intended to be
    * called from Filter::Create().
    */
-  RelationFilter(model::FieldPath field, Operator op, model::FieldValue value);
+  RelationFilter(model::FieldPath field,
+                 Operator op,
+                 model::FieldValue value_rhs);
 
   const model::FieldPath& field() const override;
 
@@ -49,7 +51,7 @@ class RelationFilter : public Filter {
 
   const model::FieldPath field_;
   const Operator op_;
-  const model::FieldValue value_;
+  const model::FieldValue value_rhs_;
 };
 
 }  // namespace core