diff options
| author |  Gil <mcg@google.com> | 2018-04-12 14:54:53 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-12 14:54:53 -0700 |
| commit | 8876622b6fcebc21672bc263666b858b7e152b45 (patch) | |
| tree | 053fe00a20207099c11c1464df25565a5f5cc3c6 /Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm | |
| parent | 1397e4ae72ea3b8d16a9b44ed1235caca47b3d9e (diff) | |
Add clang-tidy checks for Firestore (#1078)
* Add a .clang-tidy configuration for Firestore C++
* Fix clang-tidy warnings
* typedef -> using
* const ref + rvalue ref -> pass by value
* NULL -> nullptr
* remove useless default initializations
* remove useless const value-type parameter declarations (definitions
can still use them)
* use auto instead of repeating types in a cast
* Fix typos
* Address use of static method through instance warnings
* Address use after move warnings
Diffstat (limited to 'Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm')
| -rw-r--r-- | Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm b/Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm index 2bd3acc..ff2d5f7 100644 --- a/Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm +++ b/Firestore/core/src/firebase/firestore/auth/firebase_credentials_provider_apple.mm @@ -24,6 +24,7 @@ #include "Firestore/core/src/firebase/firestore/util/string_apple.h" // NB: This is also defined in Firestore/Source/Public/FIRFirestoreErrors.h +// NOLINTNEXTLINE: public constant NSString* const FIRFirestoreErrorDomain = @"FIRFirestoreErrorDomain"; namespace firebase { @@ -47,7 +48,7 @@ FirebaseCredentialsProvider::FirebaseCredentialsProvider(FIRApp* app) std::unique_lock<std::mutex> lock(contents->mutex); NSDictionary<NSString*, id>* user_info = notification.userInfo; - // ensure we're only notifiying for the current app. + // ensure we're only notifying for the current app. FIRApp* notified_app = user_info[FIRAuthStateDidChangeInternalNotificationAppKey]; if (![contents->app isEqual:notified_app]) { |