aboutsummaryrefslogtreecommitdiffhomepage
path: root/Firestore/core/include
diff options
context:
space:
mode:
authorGravatar rsgowman <rgowman@google.com>2018-02-27 13:50:50 -0500
committerGravatar GitHub <noreply@github.com>2018-02-27 13:50:50 -0500
commit13aeb61de4fac4c0239bcf44a98a7d3aa9203963 (patch)
tree47469c5470d57a6133308502e1165d335f9e91e4 /Firestore/core/include
parentf05888198a668b5d2aa75c2c8941a6b3b176b9c6 (diff)
Eliminate TypedValue and serialize direct from FieldValue to bytes. (#860)
This will likely only apply for proto messages that use 'oneof's. (Because we need to serialize these manually.) The problem was that as we were adding additional types, TypeValue was evolving into a parallel implementation of the FieldValue union. When serializing/deserializing oneofs we need to supply a custom value to serialize and a custom function to do the work. There's no value in translating from FieldValue to TypeValue just to store as this custom object. We might as well just store the FieldValue model directly and write the custom serializer/deserializer to use the model directly.
Diffstat (limited to 'Firestore/core/include')
0 files changed, 0 insertions, 0 deletions