diff options
| author |  Gil <mcg@google.com> | 2018-06-01 13:42:47 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-06-01 13:42:47 -0700 |
| commit | bb546e19885ae084823e0315e93564a44c0a8257 (patch) | |
| tree | d755ae6087bae52da506fd7f9c5570d182ee85d5 /Firestore/Source | |
| parent | 8b703e3b04f9b3784a93fe3fa579a1d8f07e981e (diff) | |
Fix Firestore compilation under Xcode < 9.2 (#1367)
* Don't rely on specialization failure to determine when std::hash is unavailable.
Instead manually declare the conditions under which std::hash should be
defined.
* Fix detection of Objective-C classes in Xcode < 9.2
std::is_base_of<NSObject, NSString>{} is false there so the overloads
defined for Objective-C types weren't getting enabled.
* Add explicit tests for StringFormat using Objective-C objects
* Add explicit tests for HasStdHash
Diffstat (limited to 'Firestore/Source')
| -rw-r--r-- | Firestore/Source/Remote/FSTSerializerBeta.mm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Firestore/Source/Remote/FSTSerializerBeta.mm b/Firestore/Source/Remote/FSTSerializerBeta.mm index ab40dd6..263fe6d 100644 --- a/Firestore/Source/Remote/FSTSerializerBeta.mm +++ b/Firestore/Source/Remote/FSTSerializerBeta.mm @@ -921,7 +921,7 @@ NS_ASSUME_NONNULL_BEGIN } else if ([filter isKindOfClass:[FSTNullFilter class]]) { proto.unaryFilter.op = GCFSStructuredQuery_UnaryFilter_Operator_IsNull; } else { - HARD_FAIL("Unrecognized filter: %s", static_cast<id>(filter)); + HARD_FAIL("Unrecognized filter: %s", filter); } return proto; } |