diff options
| author |  zxu <zxu@google.com> | 2017-12-11 15:37:01 -0500 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2017-12-11 15:37:01 -0500 |
| commit | 54ba423c87d6e0a409e4fa3dc95cd81ca16b97f7 (patch) | |
| tree | c232df19ef070105f7db11c35e7ecdf1d9b2ba07 /Firestore/Source/Public | |
| parent | c6b8c5288c2d154df0de98477ed15c54e2084fbb (diff) | |
Revisit commit method in FIRWriteBatch (#541)
* revisit FIRWriteBatch commit
* make commitWithCompletion completion nullable;
* add commit;
* add unit test;
* add swift build test for commit;
* update CHANGELOG.
Diffstat (limited to 'Firestore/Source/Public')
| -rw-r--r-- | Firestore/Source/Public/FIRWriteBatch.h | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/Firestore/Source/Public/FIRWriteBatch.h b/Firestore/Source/Public/FIRWriteBatch.h index 5f0034c..8ff1bec 100644 --- a/Firestore/Source/Public/FIRWriteBatch.h +++ b/Firestore/Source/Public/FIRWriteBatch.h @@ -94,6 +94,11 @@ NS_SWIFT_NAME(WriteBatch) /** * Commits all of the writes in this write batch as a single atomic unit. + */ +- (void)commit; + +/** + * Commits all of the writes in this write batch as a single atomic unit. * * @param completion A block to be called once all of the writes in the batch have been * successfully written to the backend as an atomic unit. This block will only execute @@ -101,7 +106,7 @@ NS_SWIFT_NAME(WriteBatch) * completion handler will not be called when the device is offline, though local * changes will be visible immediately. */ -- (void)commitWithCompletion:(void (^)(NSError *_Nullable error))completion; +- (void)commitWithCompletion:(nullable void (^)(NSError *_Nullable error))completion; @end |