Drop FSTWriteGroup (#986)

* Drop write group from remote document change buffer

* Unwind some group dependendencies in local store

* Write group dropped from local store

* Drop write group from mutation queue tests

* Drop write group usage from query cache tests

* Drop write groups from remote document cache tests

* Drop write groups from remote document change buffer tests

* Drop write groups and the write group tracker

* Style

* Put the action in transaction

* Merge master, fix test

* Fix some compiler warnings but mostly trigger travis

* Responses to feedback

1 files changed, 0 insertions, 14 deletions

diff --git a/Firestore/Source/Local/FSTMemoryPersistence.mm b/Firestore/Source/Local/FSTMemoryPersistence.mm
index f1f9885..8d74881 100644
--- a/Firestore/Source/Local/FSTMemoryPersistence.mm
+++ b/Firestore/Source/Local/FSTMemoryPersistence.mm
@@ -21,8 +21,6 @@
 #import "Firestore/Source/Local/FSTMemoryMutationQueue.h"
 #import "Firestore/Source/Local/FSTMemoryQueryCache.h"
 #import "Firestore/Source/Local/FSTMemoryRemoteDocumentCache.h"
-#import "Firestore/Source/Local/FSTWriteGroup.h"
-#import "Firestore/Source/Local/FSTWriteGroupTracker.h"
 #import "Firestore/Source/Util/FSTAssert.h"
 
 #include "Firestore/core/src/firebase/firestore/auth/user.h"
@@ -33,7 +31,6 @@ using firebase::firestore::auth::User;
 NS_ASSUME_NONNULL_BEGIN
 
 @interface FSTMemoryPersistence ()
-@property(nonatomic, strong, nonnull) FSTWriteGroupTracker *writeGroupTracker;
 @property(nonatomic, assign, getter=isStarted) BOOL started;
 @end
 
@@ -62,7 +59,6 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (instancetype)init {
   if (self = [super init]) {
-    _writeGroupTracker = [FSTWriteGroupTracker tracker];
     _queryCache = [[FSTMemoryQueryCache alloc] init];
     _remoteDocumentCache = [[FSTMemoryRemoteDocumentCache alloc] init];
   }
@@ -103,16 +99,6 @@ NS_ASSUME_NONNULL_BEGIN
   return _remoteDocumentCache;
 }
 
-- (FSTWriteGroup *)startGroupWithAction:(NSString *)action {
-  return [self.writeGroupTracker startGroupWithAction:action];
-}
-
-- (void)commitGroup:(FSTWriteGroup *)group {
-  [self.writeGroupTracker endGroup:group];
-
-  FSTAssert(group.isEmpty, @"Memory persistence shouldn't use write groups: %@", group.action);
-}
-
 @end
 
 NS_ASSUME_NONNULL_END