diff options
| author |  Gil <mcg@google.com> | 2018-04-09 11:54:39 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-09 11:54:39 -0700 |
| commit | 0a6618705389543191a8c44278d4c6791c84602a (patch) | |
| tree | 4f195f31da90b29ffa5219e016b2cfd9ad0a7ccf /Firestore/Source/Core | |
| parent | 2f2bb7f4c717bb95df69735e93ae84de8b8feaad (diff) | |
Add lint checking for Objective-C++ sources (#1048)
* lint.sh now lints Objective-C++ too
* cpplint checks system-style includes that should be user-style
This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.
* cpplint checks #imports and #includes
* cpplint checks that C++ system headers aren't #imported
* cpplint checks for C system headers that could be C++ system headers
* cpplint checks that Objective-C sources include their headers
Diffstat (limited to 'Firestore/Source/Core')
| -rw-r--r-- | Firestore/Source/Core/FSTFirestoreClient.mm | 3 | ||||
| -rw-r--r-- | Firestore/Source/Core/FSTListenSequence.mm | 2 | ||||
| -rw-r--r-- | Firestore/Source/Core/FSTQuery.mm | 1 | ||||
| -rw-r--r-- | Firestore/Source/Core/FSTSyncEngine.mm | 5 | ||||
| -rw-r--r-- | Firestore/Source/Core/FSTTransaction.mm | 4 |
5 files changed, 9 insertions, 6 deletions
diff --git a/Firestore/Source/Core/FSTFirestoreClient.mm b/Firestore/Source/Core/FSTFirestoreClient.mm index c0d38ca..33d1903 100644 --- a/Firestore/Source/Core/FSTFirestoreClient.mm +++ b/Firestore/Source/Core/FSTFirestoreClient.mm @@ -16,7 +16,8 @@ #import "Firestore/Source/Core/FSTFirestoreClient.h" -#import <future> +#include <future> // NOLINT(build/c++11) +#include <memory> #import "Firestore/Source/Core/FSTEventManager.h" #import "Firestore/Source/Core/FSTSyncEngine.h" diff --git a/Firestore/Source/Core/FSTListenSequence.mm b/Firestore/Source/Core/FSTListenSequence.mm index 6f50d35..6a9f9ae 100644 --- a/Firestore/Source/Core/FSTListenSequence.mm +++ b/Firestore/Source/Core/FSTListenSequence.mm @@ -14,7 +14,7 @@ * limitations under the License. */ -#import "FSTListenSequence.h" +#import "Firestore/Source/Core/FSTListenSequence.h" NS_ASSUME_NONNULL_BEGIN diff --git a/Firestore/Source/Core/FSTQuery.mm b/Firestore/Source/Core/FSTQuery.mm index 811ad03..8f49c26 100644 --- a/Firestore/Source/Core/FSTQuery.mm +++ b/Firestore/Source/Core/FSTQuery.mm @@ -17,6 +17,7 @@ #import "Firestore/Source/Core/FSTQuery.h" #include <memory> +#include <string> #include <utility> #import "Firestore/Source/API/FIRFirestore+Internal.h" diff --git a/Firestore/Source/Core/FSTSyncEngine.mm b/Firestore/Source/Core/FSTSyncEngine.mm index 673991c..0a4fc94 100644 --- a/Firestore/Source/Core/FSTSyncEngine.mm +++ b/Firestore/Source/Core/FSTSyncEngine.mm @@ -16,11 +16,12 @@ #import "Firestore/Source/Core/FSTSyncEngine.h" +#import <GRPCClient/GRPCCall.h> + #include <map> +#include <set> #include <unordered_map> -#import <GRPCClient/GRPCCall.h> - #import "FIRFirestoreErrors.h" #import "Firestore/Source/Core/FSTQuery.h" #import "Firestore/Source/Core/FSTSnapshotVersion.h" diff --git a/Firestore/Source/Core/FSTTransaction.mm b/Firestore/Source/Core/FSTTransaction.mm index 9e67ed4..71c1f35 100644 --- a/Firestore/Source/Core/FSTTransaction.mm +++ b/Firestore/Source/Core/FSTTransaction.mm @@ -16,11 +16,11 @@ #import "Firestore/Source/Core/FSTTransaction.h" +#import <GRPCClient/GRPCCall.h> + #include <map> #include <vector> -#import <GRPCClient/GRPCCall.h> - #import "FIRFirestoreErrors.h" #import "FIRSetOptions.h" #import "Firestore/Source/API/FSTUserDataConverter.h" |