diff options
| author |  Gil <mcg@google.com> | 2018-04-19 13:59:57 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-19 13:59:57 -0700 |
| commit | dae53d5c494e7b98ea47dd16739e7ec434e02da0 (patch) | |
| tree | 02b8242227d0e07e85d69e5de08fd5ad62b84018 /Firestore/Example/Tests | |
| parent | 9eea8d4fc480f32d57cab344c32ebe631a083e9d (diff) | |
Clean up warnings in Firestore (#1146)
Diffstat (limited to 'Firestore/Example/Tests')
| -rw-r--r-- | Firestore/Example/Tests/Util/FSTDispatchQueueTests.mm | 16 | ||||
| -rw-r--r-- | Firestore/Example/Tests/Util/FSTEventAccumulator.mm | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/Firestore/Example/Tests/Util/FSTDispatchQueueTests.mm b/Firestore/Example/Tests/Util/FSTDispatchQueueTests.mm index 60b1705..811fa34 100644 --- a/Firestore/Example/Tests/Util/FSTDispatchQueueTests.mm +++ b/Firestore/Example/Tests/Util/FSTDispatchQueueTests.mm @@ -157,7 +157,7 @@ static const FSTTimerID timerID3 = FSTTimerIDWriteStreamConnectionBackoff; __block NSException *caught = nil; dispatch_sync(_underlyingQueue, ^{ @try { - [_queue verifyIsCurrentQueue]; + [self->_queue verifyIsCurrentQueue]; } @catch (NSException *ex) { caught = ex; } @@ -172,7 +172,7 @@ static const FSTTimerID timerID3 = FSTTimerIDWriteStreamConnectionBackoff; __block NSException *caught = nil; [_queue dispatchSync:^{ @try { - [_queue verifyIsCurrentQueue]; + [self->_queue verifyIsCurrentQueue]; } @catch (NSException *ex) { caught = ex; } @@ -185,7 +185,7 @@ static const FSTTimerID timerID3 = FSTTimerIDWriteStreamConnectionBackoff; __block NSString *problem = nil; [_queue dispatchSync:^{ @try { - [_queue enterCheckedOperation:^{ + [self->_queue enterCheckedOperation:^{ }]; problem = @"Should not have been able to enter nested enterCheckedOperation"; } @catch (NSException *ex) { @@ -229,14 +229,14 @@ static const FSTTimerID timerID3 = FSTTimerIDWriteStreamConnectionBackoff; _expectedSteps = @[ @1, @3 ]; // Queue everything from the queue to ensure nothing completes before we cancel. [_queue dispatchAsync:^{ - [_queue dispatchAsyncAllowingSameQueue:[self blockForStep:1]]; + [self->_queue dispatchAsyncAllowingSameQueue:[self blockForStep:1]]; FSTDelayedCallback *step2Timer = - [_queue dispatchAfterDelay:.001 timerID:timerID1 block:[self blockForStep:2]]; - [_queue dispatchAfterDelay:.005 timerID:timerID2 block:[self blockForStep:3]]; + [self->_queue dispatchAfterDelay:.001 timerID:timerID1 block:[self blockForStep:2]]; + [self->_queue dispatchAfterDelay:.005 timerID:timerID2 block:[self blockForStep:3]]; - XCTAssertTrue([_queue containsDelayedCallbackWithTimerID:timerID1]); + XCTAssertTrue([self->_queue containsDelayedCallbackWithTimerID:timerID1]); [step2Timer cancel]; - XCTAssertFalse([_queue containsDelayedCallbackWithTimerID:timerID1]); + XCTAssertFalse([self->_queue containsDelayedCallbackWithTimerID:timerID1]); }]; [self awaitExpectations]; diff --git a/Firestore/Example/Tests/Util/FSTEventAccumulator.mm b/Firestore/Example/Tests/Util/FSTEventAccumulator.mm index c4c1602..623ba2d 100644 --- a/Firestore/Example/Tests/Util/FSTEventAccumulator.mm +++ b/Firestore/Example/Tests/Util/FSTEventAccumulator.mm @@ -75,7 +75,7 @@ NS_ASSUME_NONNULL_BEGIN id event = value ? value : [NSNull null]; @synchronized(self) { - [_events addObject:event]; + [self->_events addObject:event]; [self checkFulfilled]; } }; |