diff options
| author |  Gil <mcg@google.com> | 2018-04-09 11:54:39 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-04-09 11:54:39 -0700 |
| commit | 0a6618705389543191a8c44278d4c6791c84602a (patch) | |
| tree | 4f195f31da90b29ffa5219e016b2cfd9ad0a7ccf /Firestore/Example/Tests/Util | |
| parent | 2f2bb7f4c717bb95df69735e93ae84de8b8feaad (diff) | |
Add lint checking for Objective-C++ sources (#1048)
* lint.sh now lints Objective-C++ too
* cpplint checks system-style includes that should be user-style
This prevents it from recognizing project sources as if they were C
system headers and then complaining that they're in the wrong place.
* cpplint checks #imports and #includes
* cpplint checks that C++ system headers aren't #imported
* cpplint checks for C system headers that could be C++ system headers
* cpplint checks that Objective-C sources include their headers
Diffstat (limited to 'Firestore/Example/Tests/Util')
| -rw-r--r-- | Firestore/Example/Tests/Util/FSTHelpers.mm | 11 | ||||
| -rw-r--r-- | Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm | 7 |
2 files changed, 10 insertions, 8 deletions
diff --git a/Firestore/Example/Tests/Util/FSTHelpers.mm b/Firestore/Example/Tests/Util/FSTHelpers.mm index cc120a9..8f170e6 100644 --- a/Firestore/Example/Tests/Util/FSTHelpers.mm +++ b/Firestore/Example/Tests/Util/FSTHelpers.mm @@ -16,15 +16,16 @@ #import "Firestore/Example/Tests/Util/FSTHelpers.h" -#include <inttypes.h> -#include <list> -#include <map> -#include <vector> - #import <FirebaseFirestore/FIRFieldPath.h> #import <FirebaseFirestore/FIRGeoPoint.h> #import <FirebaseFirestore/FIRTimestamp.h> +#include <cinttypes> +#include <list> +#include <map> +#include <utility> +#include <vector> + #import "Firestore/Source/API/FIRFieldPath+Internal.h" #import "Firestore/Source/API/FSTUserDataConverter.h" #import "Firestore/Source/Core/FSTQuery.h" diff --git a/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm b/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm index 611bcc8..79163da 100644 --- a/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm +++ b/Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm @@ -16,14 +16,15 @@ #import "Firestore/Example/Tests/Util/FSTIntegrationTestCase.h" -#include <memory> -#include <utility> - #import <FirebaseCore/FIRLogger.h> #import <FirebaseFirestore/FirebaseFirestore-umbrella.h> #import <GRPCClient/GRPCCall+ChannelArg.h> #import <GRPCClient/GRPCCall+Tests.h> +#include <memory> +#include <string> +#include <utility> + #include "Firestore/core/src/firebase/firestore/auth/empty_credentials_provider.h" #include "Firestore/core/src/firebase/firestore/model/database_id.h" #include "Firestore/core/src/firebase/firestore/util/autoid.h" |