diff options
| author |  zxu <zxu@google.com> | 2018-03-16 15:42:05 -0400 |
|---|---|---|
| committer |  GitHub <noreply@github.com> | 2018-03-16 15:42:05 -0400 |
| commit | 4e7296b080b9c8cea13e5e5eeee65f4312fb5e8a (patch) | |
| tree | 87f175b1e1ac74632fee2ff7c52ccb9b5bc78014 /Firestore/Example/Tests/SpecTests/FSTSpecTests.mm | |
| parent | 1395c8202b236188b9e4e1bfc2a3e00244179593 (diff) | |
port `DocumentKey` to non-container types of `Model/*` (#930)
* naively remove FSTPath import and source/test files.
* port FieldPath, part I
* port FieldPath, part II
* port ResourcePath, part I
* port ResourcePath, part II
* the grand commit to fix build errors
* use testutil:: helper instead of those from FSTHelpers
* fix test and lint
* use c_str in errmsg directly
* fix
* fix
* make code clean
* fix integration test I missed
* fix to avoid naming collision in preprocessor
* address changes
* address changes
* address changes
* fix: fieldMask are actually shared with different context.
* address changes
* add converter function between two DocumentKey implementations
* add unit test
* address changes
* fix lint
* using DocumentKey in model except for the container types `FSTDocumentDictionary`, `FSTDocumentKeySet`, and `FSTDocumentVersionDictionary`
* change other place w.r.t. the use of `DocumentKey` in model
* update parameter of test helpers from NSString to string_view
* revert a temporary change used in debug
* address changes
Diffstat (limited to 'Firestore/Example/Tests/SpecTests/FSTSpecTests.mm')
| -rw-r--r-- | Firestore/Example/Tests/SpecTests/FSTSpecTests.mm | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Firestore/Example/Tests/SpecTests/FSTSpecTests.mm b/Firestore/Example/Tests/SpecTests/FSTSpecTests.mm index 0f57b81..10aa6c2 100644 --- a/Firestore/Example/Tests/SpecTests/FSTSpecTests.mm +++ b/Firestore/Example/Tests/SpecTests/FSTSpecTests.mm @@ -153,7 +153,9 @@ static NSString *const kNoIOSTag = @"no-ios"; } } NSNumber *version = change[1]; - FSTDocument *doc = FSTTestDoc(change[0], version.longLongValue, change[2], hasMutations); + XCTAssert([change[0] isKindOfClass:[NSString class]]); + FSTDocument *doc = FSTTestDoc(util::MakeStringView((NSString *)change[0]), version.longLongValue, + change[2], hasMutations); return [FSTDocumentViewChange changeWithDocument:doc type:type]; } |