Run FIRSetLoggerLevel and FIRIsLoggableLevel on the same thread (#592)

This fixes a race condition where a caller calls FIRSetLoggerLevel and
then checks FIRIsLoggableLevel immediately after.

1 files changed, 6 insertions, 6 deletions

diff --git a/Firebase/Core/FIRLogger.m b/Firebase/Core/FIRLogger.m
index ba22bde..2b2a0ae 100644
--- a/Firebase/Core/FIRLogger.m
+++ b/Firebase/Core/FIRLogger.m
@@ -164,13 +164,13 @@ void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel) {
     return;
   }
   FIRLoggerInitializeASL();
-  dispatch_async(sFIRClientQueue, ^{
-    // We should not raise the logger level if we are running from App Store.
-    if (loggerLevel >= FIRLoggerLevelNotice && [FIRAppEnvironmentUtil isFromAppStore]) {
-      return;
-    }
+  // We should not raise the logger level if we are running from App Store.
+  if (loggerLevel >= FIRLoggerLevelNotice && [FIRAppEnvironmentUtil isFromAppStore]) {
+    return;
+  }
 
-    sFIRLoggerMaximumLevel = loggerLevel;
+  sFIRLoggerMaximumLevel = loggerLevel;
+  dispatch_async(sFIRClientQueue, ^{
     asl_set_filter(sFIRLoggerClient, ASL_FILTER_MASK_UPTO(loggerLevel));
   });
 }