diff options
author | Ryan Wilson <wilsonryan@google.com> | 2018-04-25 09:45:36 -0400 |
---|---|---|
committer | Paul Beusterien <paulbeusterien@google.com> | 2018-04-25 06:45:36 -0700 |
commit | 260557691fae8ba34e262f480c632ab63b5133ee (patch) | |
tree | 7591bc9023e9c42e8a348758171a4fa41ed0cf19 /Example | |
parent | 98d665b7927da3c30f86919ca810f9f6fa6a354e (diff) |
Add counter for errors and warnings logged. (#1168)
* Moved writes outside of dispatch_async block.
Diffstat (limited to 'Example')
-rw-r--r-- | Example/Core/Tests/FIRLoggerTest.m | 45 |
1 files changed, 40 insertions, 5 deletions
diff --git a/Example/Core/Tests/FIRLoggerTest.m b/Example/Core/Tests/FIRLoggerTest.m index 31a495d..dfc7cc8 100644 --- a/Example/Core/Tests/FIRLoggerTest.m +++ b/Example/Core/Tests/FIRLoggerTest.m @@ -49,6 +49,8 @@ static NSString *const kMessageCode = @"I-COR000001"; @property(nonatomic) NSString *randomLogString; +@property(nonatomic, strong) id userDefaultsMock; + @end @implementation FIRLoggerTest @@ -56,6 +58,15 @@ static NSString *const kMessageCode = @"I-COR000001"; - (void)setUp { [super setUp]; FIRResetLogger(); + + // Stub NSUserDefaults for tracking the error and warning count. + _userDefaultsMock = OCMPartialMock([NSUserDefaults standardUserDefaults]); +} + +- (void)tearDown { + [super tearDown]; + + [_userDefaultsMock stopMocking]; } // Test some stable variables to make sure they weren't accidently changed. @@ -120,9 +131,9 @@ static NSString *const kMessageCode = @"I-COR000001"; - (void)testInitializeASLForDebugModeWithUserDefaults { // Stub. - id userDefaultsMock = [OCMockObject partialMockForObject:[NSUserDefaults standardUserDefaults]]; NSNumber *debugMode = @YES; - [[[userDefaultsMock stub] andReturnValue:debugMode] boolForKey:kFIRPersistedDebugModeKey]; + OCMStub([self.userDefaultsMock boolForKey:kFIRPersistedDebugModeKey]) + .andReturn(debugMode.boolValue); // Test. FIRLogError(kFIRLoggerCore, kMessageCode, @"Some error."); @@ -131,9 +142,6 @@ static NSString *const kMessageCode = @"I-COR000001"; debugMode = [[NSUserDefaults standardUserDefaults] objectForKey:kFIRPersistedDebugModeKey]; XCTAssertTrue(debugMode.boolValue); XCTAssertTrue(getFIRLoggerDebugMode()); - - // Stop. - [userDefaultsMock stopMocking]; } - (void)testMessageCodeFormat { @@ -231,6 +239,33 @@ static NSString *const kMessageCode = @"I-COR000001"; XCTAssertEqual(FIRLoggerLevelDebug, ASL_LEVEL_DEBUG); } +- (void)testErrorNumberIncrement { + OCMStub([self.userDefaultsMock integerForKey:kFIRLoggerErrorCountKey]).andReturn(10); + OCMExpect([self.userDefaultsMock setInteger:11 forKey:kFIRLoggerErrorCountKey]); + FIRLogError(kFIRLoggerCore, kMessageCode, @"Error."); + + // Use a delay since the logging is async. + OCMVerifyAllWithDelay(self.userDefaultsMock, 1); +} + +- (void)testWarningNumberIncrement { + OCMStub([self.userDefaultsMock integerForKey:kFIRLoggerWarningCountKey]).andReturn(1); + OCMExpect([self.userDefaultsMock setInteger:2 forKey:kFIRLoggerWarningCountKey]); + FIRLogWarning(kFIRLoggerCore, kMessageCode, @"Warning."); + + // Use a delay since the logging is async. + OCMVerifyAllWithDelay(self.userDefaultsMock, 1); +} + +- (void)testResetIssuesCount { + OCMExpect([self.userDefaultsMock setInteger:0 forKey:kFIRLoggerErrorCountKey]); + OCMExpect([self.userDefaultsMock setInteger:0 forKey:kFIRLoggerWarningCountKey]); + FIRResetNumberOfIssuesLogged(); + + // Use a delay since the logging is async. + OCMVerifyAllWithDelay(self.userDefaultsMock, 1); +} + // Helper functions. - (BOOL)logExists { [self drainFIRClientQueue]; |