diff options
author | Gil <mcg@google.com> | 2018-05-09 20:49:32 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-05-09 20:49:32 -0700 |
commit | 9ba088053d5680ac4720fa488367c745b994d006 (patch) | |
tree | eddcdf7ae3c3acbbcb77f2df0180dcd7d5016f4a /CONTRIBUTING.md | |
parent | 53b866443995ed8e796246d1f22a6fe47f76be6b (diff) |
Add missing tests to the Firestore project (#1254)
* Fix order of project elements
* Add immutable container tests to the Firestore project
* Fix style problems in TransformOperations
* Method names should have an initial upper case character (except
getters/setters)
* Pointers bind to the type not the name in C++
* Fix unsigned/signed comparison warning
* Make transform_operations.h Objective-C++ only
It turns out that you can't conditionally define virtual methods. This
causes multiple versions of the vtable to be emitted and when the linker
resolves all the vtable definitions for a class it picks one arbitrarily
causing failures for callers that expect some of the conditional methods
to be present.
* Add precondition_test and field_mask_test to the project
* Add field_transform_test and transform_operations_test to the project
* Clean up missing newline/excess comments
* Use braced initialization to avoid linter false positive on std::transform
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions