diff options
author | Michael Lehenbauer <mikelehen@gmail.com> | 2018-03-14 10:41:53 -0700 |
---|---|---|
committer | Paul Beusterien <paulbeusterien@google.com> | 2018-03-14 10:41:53 -0700 |
commit | 7b960fdf5986b1a7ef989125fe461d08f6aa8389 (patch) | |
tree | 15833e082cd6ab3b8104b71360e2692efba698dc | |
parent | d5afb9bbf398a72f0e30668a7f496bcdbd3d7134 (diff) |
Temporarily disable currently-over-aggressive assert for duplicate FSTDispatchQueue delayed callbacks. (#922)
-rw-r--r-- | Firestore/Source/Util/FSTDispatchQueue.mm | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/Firestore/Source/Util/FSTDispatchQueue.mm b/Firestore/Source/Util/FSTDispatchQueue.mm index 15d6e7b..52482df 100644 --- a/Firestore/Source/Util/FSTDispatchQueue.mm +++ b/Firestore/Source/Util/FSTDispatchQueue.mm @@ -230,8 +230,11 @@ NS_ASSUME_NONNULL_BEGIN block:(void (^)(void))block { // While not necessarily harmful, we currently don't expect to have multiple callbacks with the // same timerID in the queue, so defensively reject them. - FSTAssert(![self containsDelayedCallbackWithTimerID:timerID], - @"Attempted to schedule multiple callbacks with id %ld", (unsigned long)timerID); + // TODO(b/74749605): If a user change happens while offline we can end up with multiple backoff + // callbacks in the dispatch queue. This is non-harmful so I'm just disabling the assert until we + // get that cleaned up. + // FSTAssert(![self containsDelayedCallbackWithTimerID:timerID], + // @"Attempted to schedule multiple callbacks with id %ld", (unsigned long)timerID); FSTDelayedCallback *delayedCallback = [FSTDelayedCallback createAndScheduleWithQueue:self timerID:timerID delay:delay |