aboutsummaryrefslogtreecommitdiff
path: root/crypto-defects.md
diff options
context:
space:
mode:
authorGravatar Andres Erbsen <andreser@mit.edu>2017-03-16 21:18:03 -0400
committerGravatar GitHub <noreply@github.com>2017-03-16 21:18:03 -0400
commitfe6e81c08bc8b719639319d5ecf6c6d3efad1513 (patch)
treec7f9a6616506657fbc210e02597de2e76f2c1aac /crypto-defects.md
parent8ef051f6d51c696fd8ee039b29be1990083dd332 (diff)
Update crypto-defects.md
Diffstat (limited to 'crypto-defects.md')
-rw-r--r--crypto-defects.md2
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto-defects.md b/crypto-defects.md
index 057299b06..3ab75b959 100644
--- a/crypto-defects.md
+++ b/crypto-defects.md
@@ -20,4 +20,6 @@ appearing in our code.
| [ic#237002094](https://github.com/mit-plv/fiat-crypto/pull/42#issuecomment-237002094) | Barrett reduction for p256 | 1 conditional subtraction instead of 2 | unkown if ok |
| [openssl#1593](https://rt.openssl.org/Ticket/Display.html?id=1593&user=guest&pass=guest) | P384 modular reduction | carry handling | [exploitable](https://eprint.iacr.org/2011/633.pdf) |
| [go#fa09811d](https://github.com/golang/crypto/commit/84e98f45760e87786b7f24603b8166a6fa09811d) | poly1305 reduction | AMD64 asm, missing subtraction of 3 | found quickly |
+| [jose-adobe](https://blogs.adobe.com/security/2017/03/critical-vulnerability-uncovered-in-json-encryption.html) | ECDH-ES | 5 libraries | not onCurve |
+
Not covered in the above list: memory mismanagement (buffer overrun, use-after-free, uninitialized read, null dereference), timing attacks (branch, cache, instruction). While these issues are very important, there are good programming disciplines for avoiding them without verifying intricate details of the computation.