aboutsummaryrefslogtreecommitdiff
path: root/crypto-defects.md
diff options
context:
space:
mode:
authorGravatar Andres Erbsen <andres@krutt.org>2016-08-03 11:34:22 -0400
committerGravatar GitHub <noreply@github.com>2016-08-03 11:34:22 -0400
commit0ac4f106e6a4ab24492155b89f79ecd9d37f5d7a (patch)
treee5d7957202fc7d5589c0c55718e2280da1d22d1b /crypto-defects.md
parent09f49b6eb74caf65e552fcf70a23d11e6fa62133 (diff)
Note ref/sc25519.c:84 in crypto-defects.md
Diffstat (limited to 'crypto-defects.md')
-rw-r--r--crypto-defects.md1
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto-defects.md b/crypto-defects.md
index f8cf52053..a39064468 100644
--- a/crypto-defects.md
+++ b/crypto-defects.md
@@ -16,5 +16,6 @@ appearing in our code.
| [end-to-end#340](https://github.com/google/end-to-end/issues/340) | Curve25519 library | twisted Edwards coordinates | (0, 1) = ∞ |
| [CVE-2006-4339](https://web.archive.org/web/20071010042708/http://www.imc.org/ietf-openpgp/mail-archive/msg14307.html) | RSA-PKCS-1 sig. verification | irrelevant | padding check |
| [CVE-2014-3570](https://www.openssl.org/news/secadv/20150108.txt) | Bignum squaring | | |
+| [ref/sc25519.c:84](https://github.com/floodyberry/supercop/blob/master/crypto_sign/ed25519/ref/sc25519.c#L84) | x mod (order of Curve25519) | Barrett reduction (code is likely correct) | "XXX" comment |
Not covered in the above list: memory mismanagement (buffer overrun, use-after-free, uninitialized read, null dereference), timing attacks (branch, cache, instruction). While these issues are very important, there are good programming disciplines for avoiding them without verifying intricate details of the computation.