diff options
author | David Tellenbach <david.tellenbach@me.com> | 2020-08-14 17:57:56 +0200 |
---|---|---|
committer | David Tellenbach <david.tellenbach@me.com> | 2020-08-14 16:16:27 +0000 |
commit | d4a727d0926fc6ff1f1aa309613eb9680ec2fab3 (patch) | |
tree | c80a058a1829e0e129d624bbc646a5efbd969179 /unsupported/test | |
parent | d2bb6cf39650240be530a7ffd71f56fae13ca222 (diff) |
Disable min/max NaN propagation in test cxx11_tensor_expr
The current pmin/pmax implementation for Arm Neon propagate NaNs
differently than std::min/std::max.
See issue https://gitlab.com/libeigen/eigen/-/issues/1937
Diffstat (limited to 'unsupported/test')
-rw-r--r-- | unsupported/test/cxx11_tensor_expr.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/unsupported/test/cxx11_tensor_expr.cpp b/unsupported/test/cxx11_tensor_expr.cpp index 6dc44996a..b49663fe9 100644 --- a/unsupported/test/cxx11_tensor_expr.cpp +++ b/unsupported/test/cxx11_tensor_expr.cpp @@ -331,6 +331,7 @@ void test_minmax_nan_propagation_templ() { VERIFY((numext::isnan)(vec_res(i))); } + // Test that NaNs do not propagate if we reverse the arguments. vec_res = vec_zero.cwiseMin(kNan); for (int i = 0; i < size; ++i) { @@ -376,5 +377,10 @@ EIGEN_DECLARE_TEST(cxx11_tensor_expr) CALL_SUBTEST(test_type_casting()); CALL_SUBTEST(test_select()); CALL_SUBTEST(test_clip()); + +// Nan propagation does currently not work like one would expect from std::max/std::min, +// so we disable it for now +#if !EIGEN_ARCH_ARM_OR_ARM64 CALL_SUBTEST(test_minmax_nan_propagation()); +#endif } |