fix misc warnings

2 files changed, 7 insertions, 8 deletions

diff --git a/unsupported/Eigen/src/NonLinearOptimization/chkder.h b/unsupported/Eigen/src/NonLinearOptimization/chkder.h
index e2bdf923c..bc0cb1880 100644
--- a/unsupported/Eigen/src/NonLinearOptimization/chkder.h
+++ b/unsupported/Eigen/src/NonLinearOptimization/chkder.h
@@ -56,4 +56,5 @@ void chkder(
     }
 }
 
-} // end namespace internal
\ No newline at end of file
+} // end namespace internal
+
diff --git a/unsupported/Eigen/src/NonLinearOptimization/rwupdt.h b/unsupported/Eigen/src/NonLinearOptimization/rwupdt.h
index 96263f8c0..ab83f9b25 100644
--- a/unsupported/Eigen/src/NonLinearOptimization/rwupdt.h
+++ b/unsupported/Eigen/src/NonLinearOptimization/rwupdt.h
@@ -28,15 +28,12 @@ void rwupdt(
             r(i,j) = temp;
         }
 
-        if (rowj == 0.)
-        {
-          givens[j] = JacobiRotation<Scalar>(1,0);
-          continue;
-        }
-
         /* determine a givens rotation which eliminates w(j). */
         givens[j].makeGivens(-r(j,j), rowj);
 
+        if (rowj == 0.)
+            continue; // givens[j] is identity
+
         /* apply the current transformation to r(j,j), b(j), and alpha. */
         r(j,j) = givens[j].c() * r(j,j) + givens[j].s() * rowj;
         temp = givens[j].c() * b[j] + givens[j].s() * alpha;
@@ -45,4 +42,5 @@ void rwupdt(
     }
 }
 
-} // end namespace internal
\ No newline at end of file
+} // end namespace internal
+