* fix the QR module to use extract/part instead of the previous triangular stuff

* added qr and eigensolver tests
* fix a compilation warning in Matrix copy constructor

3 files changed, 118 insertions, 0 deletions

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index c96578331..6cd98800a 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -75,5 +75,7 @@ EI_ADD_TEST(product)
 EI_ADD_TEST(triangular)
 EI_ADD_TEST(cholesky)
 # EI_ADD_TEST(determinant)
+EI_ADD_TEST(qr)
+EI_ADD_TEST(eigensolver)
 
 ENDIF(BUILD_TESTS)
diff --git a/test/eigensolver.cpp b/test/eigensolver.cpp
new file mode 100644
index 000000000..f63d7a535
--- /dev/null
+++ b/test/eigensolver.cpp
@@ -0,0 +1,61 @@
+// This file is part of Eigen, a lightweight C++ template library
+// for linear algebra. Eigen itself is part of the KDE project.
+//
+// Copyright (C) 2008 Gael Guennebaud <g.gael@free.fr>
+//
+// Eigen is free software; you can redistribute it and/or
+// modify it under the terms of the GNU Lesser General Public
+// License as published by the Free Software Foundation; either
+// version 3 of the License, or (at your option) any later version.
+//
+// Alternatively, you can redistribute it and/or
+// modify it under the terms of the GNU General Public License as
+// published by the Free Software Foundation; either version 2 of
+// the License, or (at your option) any later version.
+//
+// Eigen is distributed in the hope that it will be useful, but WITHOUT ANY
+// WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+// FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License or the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public
+// License and a copy of the GNU General Public License along with
+// Eigen. If not, see <http://www.gnu.org/licenses/>.
+
+#include "main.h"
+#include <Eigen/QR>
+
+template<typename MatrixType> void eigensolver(const MatrixType& m)
+{
+  /* this test covers the following files:
+     EigenSolver.h
+  */
+  int rows = m.rows();
+  int cols = m.cols();
+
+  typedef typename std::complex<typename NumTraits<typename MatrixType::Scalar>::Real> Complex;
+
+  MatrixType a = MatrixType::random(rows,cols);
+  MatrixType covMat =  a.adjoint() * a;
+
+  EigenSolver<MatrixType,true> eiSymm(covMat);
+  VERIFY_IS_APPROX(covMat * eiSymm.eigenvectors(), eiSymm.eigenvectors() * eiSymm.eigenvalues().asDiagonal());
+
+  EigenSolver<MatrixType,false> eiNotSymmButSymm(covMat);
+  VERIFY_IS_APPROX((covMat.template cast<Complex>()) * (eiNotSymmButSymm.eigenvectors().template cast<Complex>()),
+    (eiNotSymmButSymm.eigenvectors().template cast<Complex>()) * (eiNotSymmButSymm.eigenvalues().asDiagonal()));
+
+  EigenSolver<MatrixType,false> eiNotSymm(a);
+//   VERIFY_IS_APPROX(a.template cast<Complex>() * eiNotSymm.eigenvectors().template cast<Complex>(),
+//     eiNotSymm.eigenvectors().template cast<Complex>() * eiNotSymm.eigenvalues().asDiagonal());
+
+}
+
+void test_eigensolver()
+{
+  for(int i = 0; i < 1; i++) {
+    CALL_SUBTEST( eigensolver(Matrix3f()) );
+    CALL_SUBTEST( eigensolver(Matrix4d()) );
+    CALL_SUBTEST( eigensolver(MatrixXd(7,7)) );
+  }
+}
diff --git a/test/qr.cpp b/test/qr.cpp
new file mode 100644
index 000000000..8facbac96
--- /dev/null
+++ b/test/qr.cpp
@@ -0,0 +1,55 @@
+// This file is part of Eigen, a lightweight C++ template library
+// for linear algebra. Eigen itself is part of the KDE project.
+//
+// Copyright (C) 2008 Gael Guennebaud <g.gael@free.fr>
+//
+// Eigen is free software; you can redistribute it and/or
+// modify it under the terms of the GNU Lesser General Public
+// License as published by the Free Software Foundation; either
+// version 3 of the License, or (at your option) any later version.
+//
+// Alternatively, you can redistribute it and/or
+// modify it under the terms of the GNU General Public License as
+// published by the Free Software Foundation; either version 2 of
+// the License, or (at your option) any later version.
+//
+// Eigen is distributed in the hope that it will be useful, but WITHOUT ANY
+// WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+// FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License or the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public
+// License and a copy of the GNU General Public License along with
+// Eigen. If not, see <http://www.gnu.org/licenses/>.
+
+#include "main.h"
+#include <Eigen/QR>
+
+template<typename MatrixType> void qr(const MatrixType& m)
+{
+  /* this test covers the following files:
+     QR.h
+  */
+  int rows = m.rows();
+  int cols = m.cols();
+
+  typedef typename MatrixType::Scalar Scalar;
+  typedef Matrix<Scalar, MatrixType::ColsAtCompileTime, MatrixType::ColsAtCompileTime> SquareMatrixType;
+  typedef Matrix<Scalar, MatrixType::ColsAtCompileTime, 1> VectorType;
+
+  MatrixType a = MatrixType::random(rows,cols);
+  QR<MatrixType> qrOfA(a);
+
+  VERIFY_IS_APPROX(a, qrOfA.matrixQ() * qrOfA.matrixR());
+  VERIFY_IS_NOT_APPROX(a+MatrixType::identity(rows, cols), qrOfA.matrixQ() * qrOfA.matrixR());
+}
+
+void test_qr()
+{
+  for(int i = 0; i < 1; i++) {
+    CALL_SUBTEST( qr(Matrix2f()) );
+    CALL_SUBTEST( qr(Matrix3d()) );
+    CALL_SUBTEST( qr(MatrixXf(12,8)) );
+//     CALL_SUBTEST( qr(MatrixXcd(17,7)) ); // complex numbers are not supported yet
+  }
+}