fix 168 : now TriangularView::solve returns by value making TriangularView::solveInPlace less important.

Also fix the very outdated documentation of this function.

1 files changed, 6 insertions, 0 deletions

diff --git a/test/product_trsolve.cpp b/test/product_trsolve.cpp
index f9ad049a4..c207cc500 100644
--- a/test/product_trsolve.cpp
+++ b/test/product_trsolve.cpp
@@ -28,12 +28,18 @@
     (XB).setRandom(); ref = (XB); \
     (TRI).solveInPlace(XB); \
     VERIFY_IS_APPROX((TRI).toDenseMatrix() * (XB), ref); \
+    (XB).setRandom(); ref = (XB); \
+    (XB) = (TRI).solve(XB); \
+    VERIFY_IS_APPROX((TRI).toDenseMatrix() * (XB), ref); \
   }
 
 #define VERIFY_TRSM_ONTHERIGHT(TRI,XB) { \
     (XB).setRandom(); ref = (XB); \
     (TRI).transpose().template solveInPlace<OnTheRight>(XB.transpose()); \
     VERIFY_IS_APPROX((XB).transpose() * (TRI).transpose().toDenseMatrix(), ref.transpose()); \
+    (XB).setRandom(); ref = (XB); \
+    (XB).transpose() = (TRI).transpose().template solve<OnTheRight>(XB.transpose()); \
+    VERIFY_IS_APPROX((XB).transpose() * (TRI).transpose().toDenseMatrix(), ref.transpose()); \
   }
 
 template<typename Scalar,int Size, int Cols> void trsolve(int size=Size,int cols=Cols)