diff options
author | Antonio Sanchez <cantonios@google.com> | 2021-01-20 19:00:09 -0800 |
---|---|---|
committer | Rasmus Munk Larsen <rmlarsen@google.com> | 2021-01-21 19:32:28 +0000 |
commit | b2126fd6b5e232d072ceadb1abb6695ae3352e2e (patch) | |
tree | b86944d559717eeee3589efa21dcfd30cbdd2f3d /test/packetmath.cpp | |
parent | 25d8498f8ba29c8dc055dd56113facbdbe154345 (diff) |
Fix pfrexp/pldexp for half.
The recent addition of vectorized pow (!330) relies on `pfrexp` and
`pldexp`. This was missing for `Eigen::half` and `Eigen::bfloat16`.
Adding tests for these packet ops also exposed an issue with handling
negative values in `pfrexp`, returning an incorrect exponent.
Added the missing implementations, corrected the exponent in `pfrexp1`,
and added `packetmath` tests.
Diffstat (limited to 'test/packetmath.cpp')
-rw-r--r-- | test/packetmath.cpp | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/test/packetmath.cpp b/test/packetmath.cpp index ab9bec183..b7562e6a1 100644 --- a/test/packetmath.cpp +++ b/test/packetmath.cpp @@ -46,6 +46,21 @@ inline bool REF_MUL(const bool& a, const bool& b) { return a && b; } +template <typename T> +inline T REF_FREXP(const T& x, T& exp) { + int iexp; + EIGEN_USING_STD(frexp) + const T out = static_cast<T>(frexp(x, &iexp)); + exp = static_cast<T>(iexp); + return out; +} + +template <typename T> +inline T REF_LDEXP(const T& x, const T& exp) { + EIGEN_USING_STD(ldexp) + return static_cast<T>(ldexp(x, static_cast<int>(exp))); +} + // Uses pcast to cast from one array to another. template <typename SrcPacket, typename TgtPacket, int SrcCoeffRatio, int TgtCoeffRatio> struct pcast_array; @@ -552,6 +567,17 @@ void packetmath_real() { data2[i] = Scalar(internal::random<double>(-87, 88)); } CHECK_CWISE1_IF(PacketTraits::HasExp, std::exp, internal::pexp); + CHECK_CWISE1_BYREF1_IF(PacketTraits::HasExp, REF_FREXP, internal::pfrexp); + for (int i = 0; i < PacketSize; ++i) { + data1[i] = Scalar(internal::random<double>(-1, 1)); + data2[i] = Scalar(internal::random<double>(-1, 1)); + } + for (int i = 0; i < PacketSize; ++i) { + data1[i+PacketSize] = Scalar(internal::random<int>(0, 4)); + data2[i+PacketSize] = Scalar(internal::random<double>(0, 4)); + } + CHECK_CWISE2_IF(PacketTraits::HasExp, REF_LDEXP, internal::pldexp); + for (int i = 0; i < size; ++i) { data1[i] = Scalar(internal::random<double>(-1, 1) * std::pow(10., internal::random<double>(-6, 6))); data2[i] = Scalar(internal::random<double>(-1, 1) * std::pow(10., internal::random<double>(-6, 6))); |