aboutsummaryrefslogtreecommitdiffhomepage
path: root/Eigen/src
diff options
context:
space:
mode:
authorGravatar Benoit Jacob <jacob.benoit.1@gmail.com>2008-08-24 20:53:04 +0000
committerGravatar Benoit Jacob <jacob.benoit.1@gmail.com>2008-08-24 20:53:04 +0000
commitbf31d81aac6e5fcec4e8f3ac0bd626b7fb249417 (patch)
tree579b21cac035557c127f83a8ac8154a8ae13dd8a /Eigen/src
parentd3529e9c4051a2442d374f02717b2f877ccf9f19 (diff)
argh, gael you're more clever than i remembered. diagonal product is
optimized. so, i almost revert, just reordering to reduce # of load/store.
Diffstat (limited to 'Eigen/src')
-rw-r--r--Eigen/src/Geometry/Transform.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/Eigen/src/Geometry/Transform.h b/Eigen/src/Geometry/Transform.h
index 16e552fdd..1b68a37e5 100644
--- a/Eigen/src/Geometry/Transform.h
+++ b/Eigen/src/Geometry/Transform.h
@@ -388,7 +388,7 @@ Transform<Scalar,Dim>::fromPositionOrientationScale(const MatrixBase<PositionDer
const OrientationType& orientation, const MatrixBase<ScaleDerived> &scale)
{
linear() = ToRotationMatrix<Scalar,Dim,OrientationType>::convert(orientation);
- for(int i = 0; i < Dim; i++) linear().col(i) *= scale.coeff(i);
+ linear() *= scale.asDiagonal();
translation() = position;
m_matrix(Dim,Dim) = 1.;
m_matrix.template block<1,Dim>(Dim,0).setZero();