split and add unit tests for symm and syrk,

the .rank*update() functions now returns a reference to *this

3 files changed, 12 insertions, 6 deletions

diff --git a/Eigen/src/Core/SelfAdjointView.h b/Eigen/src/Core/SelfAdjointView.h
index b1b4f9e32..4787bcbd8 100644
--- a/Eigen/src/Core/SelfAdjointView.h
+++ b/Eigen/src/Core/SelfAdjointView.h
@@ -120,23 +120,25 @@ template<typename MatrixType, unsigned int UpLo> class SelfAdjointView
 
     /** Perform a symmetric rank 2 update of the selfadjoint matrix \c *this:
       * \f$ this = this + \alpha ( u v^* + v u^*) \f$
+      * \returns a reference to \c *this
       *
       * The vectors \a u and \c v \b must be column vectors, however they can be
       * a adjoint expression without any overhead. Only the meaningful triangular
       * part of the matrix is updated, the rest is left unchanged.
       */
     template<typename DerivedU, typename DerivedV>
-    void rank2update(const MatrixBase<DerivedU>& u, const MatrixBase<DerivedV>& v, Scalar alpha = Scalar(1));
+    SelfAdjointView& rank2update(const MatrixBase<DerivedU>& u, const MatrixBase<DerivedV>& v, Scalar alpha = Scalar(1));
 
     /** Perform a symmetric rank K update of the selfadjoint matrix \c *this:
-      * \f$ this = this + \alpha ( u u^* ) \f$
-      * where \a u is a vector or matrix.
+      * \f$ this = this + \alpha ( u u^* ) \f$ where \a u is a vector or matrix.
+      * 
+      * \returns a reference to \c *this
       *
       * Note that to perform \f$ this = this + \alpha ( u^* u ) \f$ you can simply
       * call this function with u.adjoint().
       */
     template<typename DerivedU>
-    void rankKupdate(const MatrixBase<DerivedU>& u, Scalar alpha = Scalar(1));
+    SelfAdjointView& rankKupdate(const MatrixBase<DerivedU>& u, Scalar alpha = Scalar(1));
 
 /////////// Cholesky module ///////////
 
diff --git a/Eigen/src/Core/products/SelfadjointProduct.h b/Eigen/src/Core/products/SelfadjointProduct.h
index b4ca4e786..08df9e15c 100644
--- a/Eigen/src/Core/products/SelfadjointProduct.h
+++ b/Eigen/src/Core/products/SelfadjointProduct.h
@@ -126,7 +126,7 @@ struct ei_selfadjoint_product<Scalar,MatStorageOrder, ColMajor, AAT, UpLo>
 
 template<typename MatrixType, unsigned int UpLo>
 template<typename DerivedU>
-void SelfAdjointView<MatrixType,UpLo>
+SelfAdjointView<MatrixType,UpLo>& SelfAdjointView<MatrixType,UpLo>
 ::rankKupdate(const MatrixBase<DerivedU>& u, Scalar alpha)
 {
   typedef ei_blas_traits<DerivedU> UBlasTraits;
@@ -144,6 +144,8 @@ void SelfAdjointView<MatrixType,UpLo>
     !UBlasTraits::NeedToConjugate, UpLo>
     ::run(_expression().cols(), actualU.cols(), &actualU.coeff(0,0), actualU.stride(),
           const_cast<Scalar*>(_expression().data()), _expression().stride(), actualAlpha);
+
+  return *this;
 }
 
 
diff --git a/Eigen/src/Core/products/SelfadjointRank2Update.h b/Eigen/src/Core/products/SelfadjointRank2Update.h
index edb57ecd5..6c8a28f65 100644
--- a/Eigen/src/Core/products/SelfadjointRank2Update.h
+++ b/Eigen/src/Core/products/SelfadjointRank2Update.h
@@ -69,7 +69,7 @@ template<bool Cond, typename T> struct ei_conj_expr_if
 
 template<typename MatrixType, unsigned int UpLo>
 template<typename DerivedU, typename DerivedV>
-void SelfAdjointView<MatrixType,UpLo>
+SelfAdjointView<MatrixType,UpLo>& SelfAdjointView<MatrixType,UpLo>
 ::rank2update(const MatrixBase<DerivedU>& u, const MatrixBase<DerivedV>& v, Scalar alpha)
 {
   typedef ei_blas_traits<DerivedU> UBlasTraits;
@@ -91,6 +91,8 @@ void SelfAdjointView<MatrixType,UpLo>
     typename ei_conj_expr_if<IsRowMajor ^ VBlasTraits::NeedToConjugate,_ActualVType>::ret,
     (IsRowMajor ? (UpLo==UpperTriangular ? LowerTriangular : UpperTriangular) : UpLo)>
     ::run(const_cast<Scalar*>(_expression().data()),_expression().stride(),actualU,actualV,actualAlpha);
+
+  return *this;
 }
 
 #endif // EIGEN_SELFADJOINTRANK2UPTADE_H