Implement evaluator for sparse-selfadjoint products

1 files changed, 3 insertions, 0 deletions

diff --git a/Eigen/src/SparseCore/SparseAssign.h b/Eigen/src/SparseCore/SparseAssign.h
index 528d63e35..f3da8c6c4 100644
--- a/Eigen/src/SparseCore/SparseAssign.h
+++ b/Eigen/src/SparseCore/SparseAssign.h
@@ -127,6 +127,7 @@ template<typename Derived>
 template<typename OtherDerived>
 Derived& SparseMatrixBase<Derived>::operator=(const EigenBase<OtherDerived> &other)
 {
+  // TODO use the evaluator mechanism
   other.derived().evalTo(derived());
   return derived();
 }
@@ -135,6 +136,7 @@ template<typename Derived>
 template<typename OtherDerived>
 Derived& SparseMatrixBase<Derived>::operator=(const ReturnByValue<OtherDerived>& other)
 {
+  // TODO use the evaluator mechanism
   other.evalTo(derived());
   return derived();
 }
@@ -143,6 +145,7 @@ template<typename Derived>
 template<typename OtherDerived>
 inline Derived& SparseMatrixBase<Derived>::operator=(const SparseMatrixBase<OtherDerived>& other)
 {
+  // FIXME, by default sparse evaluation do not alias, so we should be able to bypass the generic call_assignment
   internal::call_assignment/*_no_alias*/(derived(), other.derived());
   return derived();
 }