diff options
| author |  Benoit Jacob <jacob.benoit.1@gmail.com> | 2010-12-30 04:18:40 -0500 |
|---|---|---|
| committer | Benoit Jacob <jacob.benoit.1@gmail.com> | 2010-12-30 04:18:40 -0500 |
| commit | dbd9c5fd50cde5d5beaae44147eca3ba11934721 (patch) | |
| tree | ddd24b94e4c3b83a6aaaae11f4015e966946f113 /Eigen/src/QR | |
| parent | e112ad8124ef725149ab6b5ca5c1b6c2008aadf7 (diff) | |
fix HouseholderSequence API, bug #50:
* remove ctors taking more than 2 ints
* rename actualVectors to length
* add length/shift/trans accessors/mutators
Diffstat (limited to 'Eigen/src/QR')
| -rw-r--r-- | Eigen/src/QR/ColPivHouseholderQR.h | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/Eigen/src/QR/ColPivHouseholderQR.h b/Eigen/src/QR/ColPivHouseholderQR.h index 21ad0febe..c8ecf2c43 100644 --- a/Eigen/src/QR/ColPivHouseholderQR.h +++ b/Eigen/src/QR/ColPivHouseholderQR.h @@ -483,13 +483,10 @@ struct solve_retval<ColPivHouseholderQR<_MatrixType>, Rhs> typename Rhs::PlainObject c(rhs()); // Note that the matrix Q = H_0^* H_1^*... so its inverse is Q^* = (H_0 H_1 ...)^T - c.applyOnTheLeft(householderSequence( - dec().matrixQR(), - dec().hCoeffs(), - true, - dec().nonzeroPivots(), - 0 - )); + c.applyOnTheLeft(householderSequence(dec().matrixQR(), dec().hCoeffs()) + .setTrans(true) + .setLength(dec().nonzeroPivots()) + ); dec().matrixQR() .topLeftCorner(nonzero_pivots, nonzero_pivots) @@ -517,7 +514,7 @@ typename ColPivHouseholderQR<MatrixType>::HouseholderSequenceType ColPivHousehol ::householderQ() const { eigen_assert(m_isInitialized && "ColPivHouseholderQR is not initialized."); - return HouseholderSequenceType(m_qr, m_hCoeffs.conjugate(), false, m_nonzero_pivots, 0); + return HouseholderSequenceType(m_qr, m_hCoeffs.conjugate()).setLength(m_nonzero_pivots); } /** \return the column-pivoting Householder QR decomposition of \c *this. |