diff options
author | Gael Guennebaud <g.gael@free.fr> | 2011-05-23 13:34:04 +0200 |
---|---|---|
committer | Gael Guennebaud <g.gael@free.fr> | 2011-05-23 13:34:04 +0200 |
commit | 46bee5682fc41a8e2ad1f563b6362a9297ca3094 (patch) | |
tree | 2dc3af69d997b997ea9c5e55b8fb18ce84317e09 /Eigen/src/QR | |
parent | 074b067624e45c8e9f42f2347509d06d0d437226 (diff) |
clean a bit previous patch (ctor vs static_cast and a few bits)
Diffstat (limited to 'Eigen/src/QR')
-rw-r--r-- | Eigen/src/QR/ColPivHouseholderQR.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Eigen/src/QR/ColPivHouseholderQR.h b/Eigen/src/QR/ColPivHouseholderQR.h index 8a81fa8ed..2fa85722e 100644 --- a/Eigen/src/QR/ColPivHouseholderQR.h +++ b/Eigen/src/QR/ColPivHouseholderQR.h @@ -387,7 +387,7 @@ ColPivHouseholderQR<MatrixType>& ColPivHouseholderQR<MatrixType>::compute(const for(Index k = 0; k < cols; ++k) m_colSqNorms.coeffRef(k) = m_qr.col(k).squaredNorm(); - RealScalar threshold_helper = m_colSqNorms.maxCoeff() * internal::abs2(NumTraits<Scalar>::epsilon()) / static_cast<double>(rows); + RealScalar threshold_helper = m_colSqNorms.maxCoeff() * internal::abs2(NumTraits<Scalar>::epsilon()) / RealScalar(rows); m_nonzero_pivots = size; // the generic case is that in which all pivots are nonzero (invertible case) m_maxpivot = RealScalar(0); @@ -413,7 +413,7 @@ ColPivHouseholderQR<MatrixType>& ColPivHouseholderQR<MatrixType>::compute(const // Note that here, if we test instead for "biggest == 0", we get a failure every 1000 (or so) // repetitions of the unit test, with the result of solve() filled with large values of the order // of 1/(size*epsilon). - if(biggest_col_sq_norm < threshold_helper * static_cast<double>(rows-k)) + if(biggest_col_sq_norm < threshold_helper * RealScalar(rows-k)) { m_nonzero_pivots = k; m_hCoeffs.tail(size-k).setZero(); |