diff options
| author |  Gael Guennebaud <g.gael@free.fr> | 2009-01-20 10:37:39 +0000 |
|---|---|---|
| committer | Gael Guennebaud <g.gael@free.fr> | 2009-01-20 10:37:39 +0000 |
| commit | 3e5b3a33fadc6611f2c577fab69c7520afbe5a1b (patch) | |
| tree | 41ede2296a41000f7a16ea6929c9b4f243efd65f /Eigen/src/QR | |
| parent | 8690ba923ce73748c1b34e3f90756f0e7154fa48 (diff) | |
quick bugfix in QR::isFullRank() (not 100% sure about the reference value
for the comparison to 0)
Diffstat (limited to 'Eigen/src/QR')
| -rw-r--r-- | Eigen/src/QR/QR.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Eigen/src/QR/QR.h b/Eigen/src/QR/QR.h index 88914af3a..7712bfbf2 100644 --- a/Eigen/src/QR/QR.h +++ b/Eigen/src/QR/QR.h @@ -57,7 +57,7 @@ template<typename MatrixType> class QR } /** \returns whether or not the matrix is of full rank */ - bool isFullRank() const { return ei_isMuchSmallerThan(m_hCoeffs.cwise().abs().minCoeff(), Scalar(1)); } + bool isFullRank() const { return !ei_isMuchSmallerThan(m_qr.diagonal().cwise().abs().minCoeff(), Scalar(1)); } /** \returns a read-only expression of the matrix R of the actual the QR decomposition */ const Part<NestByValue<MatrixRBlockType>, UpperTriangular> |